Review main Merged

70678[TASK] Use multi record selection in recycler module

Oli Bartsch CR +2 V +2 Normal +81 −67 updated 08/23/21, 11:54

Commit message

The multi record selection component is now also used
in the recycler module. This increases consistency, as
custom checkbox logic could be removed.

Also the recyclers' JavaScript implementation of the
selection actions is simplified. To interact with the
multi record selection component, some events are used.
This also means, the functionality stays the same, while
most of it is now handled by the Multi record selection
component.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1420

  1. Oli Bartsch uploaded patch set 1 08/18/21, 13:58

  2. Oli Bartsch uploaded patch set 2 08/18/21, 14:04

  3. core-ci voted on patch set 1 V -1 08/18/21, 14:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15267

  4. core-ci voted on patch set 2 V -1 08/18/21, 14:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15268

  5. Oli Bartsch uploaded patch set 3 08/18/21, 14:42

  6. Oli Bartsch uploaded patch set 4 08/18/21, 14:52

  7. core-ci voted on patch set 3 V +1 08/18/21, 15:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15269

  8. core-ci voted on patch set 4 V +1 08/18/21, 15:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15270

  9. Oli Bartsch commented on patch set 4 V -1 08/18/21, 15:13

  10. Oli Bartsch marked it work in progress 08/18/21, 16:32

  11. Oli Bartsch rebased onto patch set 5 08/19/21, 08:05

  12. Oli Bartsch uploaded patch set 6 08/19/21, 08:22

  13. Oli Bartsch commented on patch set 6 08/19/21, 08:23

    This change is ready for review.
  14. core-ci voted on patch set 5 V +1 08/19/21, 08:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15297

  15. core-ci voted on patch set 6 V +1 08/19/21, 08:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15299

  16. Jochen Roth commented on patch set 6 V +1 CR +1 08/19/21, 08:53

  17. Simon Schaufelberger commented on patch set 6 V -1 CR -1 08/20/21, 16:20

    Once you select a few entries manually and then unselect all, the background color stays should reset as well. Tested on Chrome under Ubuntu
  18. Simon Schaufelberger commented on patch set 6 V +1 CR +1 08/20/21, 16:23

    sorry, had some old files in the browser cache. The background color is correctly reset now.
  19. Benni Mack voted on patch set 6 V +2 CR +2 08/23/21, 11:53

  20. Benni Mack merged patch set 7 08/23/21, 11:54