70678[TASK] Use multi record selection in recycler module
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Jochen Roth +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Jochen Roth +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/recycler/Resources/Public/TypeScript/Recycler.ts+23 −41
- typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php+1 −0
- typo3/sysext/recycler/Resources/Private/Partials/RecordsTable/DeletedRecord.html+3 −4
- typo3/sysext/recycler/Resources/Private/Templates/RecyclerModule/Index.html+53 −21
- typo3/sysext/recycler/Resources/Public/JavaScript/Recycler.js+1 −1
Review log 1420
-
Oli Bartsch uploaded patch set 1 08/18/21, 13:58
-
Oli Bartsch uploaded patch set 2 08/18/21, 14:04
-
core-ci voted on patch set 1 V -1 08/18/21, 14:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15267
-
core-ci voted on patch set 2 V -1 08/18/21, 14:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15268
-
Oli Bartsch uploaded patch set 3 08/18/21, 14:42
-
Oli Bartsch uploaded patch set 4 08/18/21, 14:52
-
core-ci voted on patch set 3 V +1 08/18/21, 15:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15269
-
core-ci voted on patch set 4 V +1 08/18/21, 15:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15270
-
Oli Bartsch commented on patch set 4 V -1 08/18/21, 15:13
Has to wait for https://review.typo3.org/c/Packages/TYPO3.CMS/+/70675 -
Oli Bartsch marked it work in progress 08/18/21, 16:32
-
Oli Bartsch rebased onto patch set 5 08/19/21, 08:05
-
Oli Bartsch uploaded patch set 6 08/19/21, 08:22
-
Oli Bartsch commented on patch set 6 08/19/21, 08:23
This change is ready for review. -
core-ci voted on patch set 5 V +1 08/19/21, 08:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15297
-
core-ci voted on patch set 6 V +1 08/19/21, 08:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15299
-
Jochen Roth commented on patch set 6 V +1 CR +1 08/19/21, 08:53
Looks good when is https://review.typo3.org/c/Packages/TYPO3.CMS/+/70675 -
Simon Schaufelberger commented on patch set 6 V -1 CR -1 08/20/21, 16:20
Once you select a few entries manually and then unselect all, the background color stays should reset as well. Tested on Chrome under Ubuntu -
Simon Schaufelberger commented on patch set 6 V +1 CR +1 08/20/21, 16:23
sorry, had some old files in the browser cache. The background color is correctly reset now. -
Benni Mack voted on patch set 6 V +2 CR +2 08/23/21, 11:53
-
Benni Mack merged patch set 7 08/23/21, 11:54