Review main Merged

70681[TASK] Streamline and modernize the new form wizard

Andreas Steiger CR +2 V +2 Hard +255 −196 updated 09/03/21, 14:14

Commit message

Streamline and optimize styling and markup of the new form wizard
of form manager.

* Clean up markup and use common colors of TYPO3 v11
* Optimize UX and Overview of the new form wizard
* Use new common styles and elements for better overview and modern look

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Tobias Siegler +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • waldhacker +2
    • Tobias Siegler +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 2841

Show 916 earlier messages
  1. Andreas Steiger uploaded patch set 1 08/18/21, 21:13

  2. Andreas Steiger updated the commit message in patch set 2 08/18/21, 21:15

  3. core-ci voted on patch set 1 V -1 08/18/21, 21:26 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15290

  4. core-ci voted on patch set 2 V -1 08/18/21, 21:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15291

  5. Tobias Siegler uploaded patch set 3 09/02/21, 11:41

  6. core-ci voted on patch set 3 V -1 09/02/21, 11:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16069

  7. Tobias Siegler uploaded patch set 4 09/02/21, 13:57

  8. core-ci voted on patch set 4 V -1 09/02/21, 14:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16084

  9. Tobias Siegler uploaded patch set 5 09/02/21, 14:41

  10. Tobias Siegler commented on patch set 6 09/02/21, 14:46

    Published edit on patch set 5.
  11. Tobias Siegler updated the commit message in patch set 7 09/02/21, 14:48

  12. core-ci voted on patch set 5 V +1 09/02/21, 14:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16090

  13. core-ci voted on patch set 6 V +1 09/02/21, 15:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16093

  14. Nikita Hovratov commented on patch set 7 09/02/21, 15:26

    MultiStepWizard.ts:147

    This shouldn't be hardcoded here.

    MultiStepWizard.ts:151

    This shouldn't be hardcoded here. Not sure either if giving the button a warning color makes sense, as it is not semantically correct. I see how the color combination of black/orange looks good and fits to the TYPO3 color scheme, but right now the orange color is used as a warning sign, for instance for deleting things.
  15. core-ci voted on patch set 7 V +1 09/02/21, 15:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16096

  16. Björn Jacob voted on patch set 7 V +1 CR +1 09/03/21, 06:18

  1. Tobias Siegler commented on patch set 7 09/03/21, 07:22

    MultiStepWizard.ts:147 Reply Unresolved

    There is no "btn-notice" style. And since the modal styles are now kept gray, we had to go this way.

    MultiStepWizard.ts:151 Reply

    Yes, you're right that the warning color isn't so good. But, it looks like this is currently the way how the backend handles it - see the "Add dashboard" wizard.
  2. Nikita Hovratov commented on patch set 7 CR -1 09/03/21, 08:30

    MultiStepWizard.ts:403 Unresolved

    This won't work anymore, because the button severity is not bound anymore to the whole modal's severity.
  3. Nikita Hovratov commented on patch set 7 09/03/21, 08:44

    MultiStepWizard.ts:151 Reply Unresolved

    Yep, but I wouldn't continue a wrong approach just because it was used at one place. The solution right now is also not the best. The buttons color should be configurable decoupled from the slide's severity. Maybe it needs a discussion about the future backend styleguide of TYPO3. Right now I would stick to the current norm, so we don't have mixed styles across the backend. So btn-primary would fit best I believe.
  4. waldhacker uploaded patch set 8 09/03/21, 09:36

  5. waldhacker commented on patch set 8 09/03/21, 09:37

    I have pushed a few minor cleanups in the viewmodel
  6. core-ci voted on patch set 8 V +1 09/03/21, 09:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16161

  7. Tobias Siegler uploaded patch set 9 09/03/21, 11:59

  8. core-ci voted on patch set 9 V +1 09/03/21, 12:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16173

  9. Tobias Siegler uploaded patch set 10 09/03/21, 12:34

  10. Björn Jacob uploaded patch set 11 09/03/21, 12:47

  11. core-ci voted on patch set 10 V -1 09/03/21, 12:53 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16175

  12. Björn Jacob commented on patch set 11 V +1 CR +1 09/03/21, 12:54

    After some discussion and sort of smoking heads we decided the following: * Nikita is right, we must not change the API i.e. the multistep wizard must not be changed * that said we have rolled back the changes in the mentioned file * we have created a new issue (https://forge.typo3.org/issues/95098) which collects all the modals and their severities -> there is definitely stuff to do This patch should be fine now and is ready for merging. Changing the modal is out of scope.
  13. Tobias Siegler voted on patch set 11 V +1 CR +1 09/03/21, 12:56

  14. core-ci voted on patch set 11 V +1 09/03/21, 13:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16177

  15. Tobias Siegler rebased onto patch set 12 09/03/21, 13:14

  16. Björn Jacob voted on patch set 12 V +1 CR +1 09/03/21, 13:15

  17. Tobias Siegler voted on patch set 12 V +1 CR +1 09/03/21, 13:19

  18. Nikita Hovratov commented on patch set 12 V +1 09/03/21, 13:21

    Should we mention, that this changes the global color of the progress bar?

    _main.scss:309 Unresolved

    Should we mention, that this changes the progress-bar color in all modals?
  19. core-ci voted on patch set 12 V +1 09/03/21, 13:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16178

  20. Tobias Siegler uploaded patch set 13 09/03/21, 13:44

  21. Tobias Siegler voted on patch set 13 V +1 CR +1 09/03/21, 13:52

  22. Nikita Hovratov voted on patch set 13 V +1 CR +1 09/03/21, 13:57

  23. core-ci voted on patch set 13 V +1 09/03/21, 14:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16185

  24. waldhacker voted on patch set 13 V +2 CR +2 09/03/21, 14:13

  25. waldhacker merged patch set 14 09/03/21, 14:14