Review main Merged

70682[TASK] Use multi record selection in workspace module

Oli Bartsch CR +2 V +2 Normal +89 −55 updated 08/20/21, 10:15

Commit message

The multi record selection component is now also used
in the workspaces module. This increases consistency,
as custom checkbox logic could be removed.

Furthermore are the actions now shown above and
below the listing, similar to the recycler module.

Thanks to additional labels, it's now also clear what
each action is for and which records are affected.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 45

  1. Oli Bartsch uploaded patch set 1 08/19/21, 13:59

  2. core-ci voted on patch set 1 V +1 08/19/21, 14:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15304

  3. Jochen Roth voted on patch set 1 V +1 CR +1 08/20/21, 08:14

  4. Benni Mack voted on patch set 1 V +2 CR +2 08/20/21, 10:15

  5. Benni Mack merged patch set 2 08/20/21, 10:15