70684[BUGFIX] Reactivate preset actions in current EXT:impexp
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Tests/Acceptance/Backend/Impexp/AbstractCest.php+20 −2
- typo3/sysext/core/Tests/Acceptance/Backend/Impexp/ExportCest.php+73 −57
- typo3/sysext/core/Tests/Acceptance/Backend/Impexp/ImportCest.php+15 −59
- typo3/sysext/core/Tests/Acceptance/Backend/Impexp/UsersCest.php+11 −37
- typo3/sysext/impexp/Classes/Controller/ExportController.php+1 −1
Review log 1117
-
Alexander Nitsche uploaded patch set 1 08/19/21, 22:08
-
core-ci voted on patch set 1 V -1 08/19/21, 22:28 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15314
-
Alexander Nitsche uploaded patch set 2 08/20/21, 05:02
-
core-ci voted on patch set 2 V +1 08/20/21, 05:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15319
-
Alexander Nitsche uploaded patch set 3 08/20/21, 14:52
-
core-ci voted on patch set 3 V +1 08/20/21, 15:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15328
-
Alexander Nitsche updated the commit message in patch set 4 08/20/21, 15:20
-
Alexander Nitsche commented on patch set 4 08/20/21, 15:22
This patch is only about one line of code where it fetches $_POST instead of $_GET. The remainder is about an according acceptance test and some re-organisation of the EXT:impexp acceptance tests which run still fine. -
Alexander Nitsche commented on patch set 4 08/20/21, 15:30
Perform testing by ### Without this patch Logging into TYPO3 backend > List > Right click on page tree item > More options > Export > Tab "File & Preset" > Insert "MyFirstPreset" in "Title of new preset" > Click button "Save" ==> Confirm that no flash message is shown & confirm that there is no preset "MyFirstPreset" available in "Select preset" ### With this patch Same steps in browser as for section "Without this patch" ==> Confirm that a flash message is shown & confirm that there is a preset "MyFirstPreset" available in "Select preset" -
core-ci voted on patch set 4 V +1 08/20/21, 15:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15333
-
Alexander Nitsche updated the commit message in patch set 5 08/20/21, 17:25
-
core-ci voted on patch set 5 V +1 08/20/21, 17:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15340
-
Christian Kuhn uploaded patch set 6 08/23/21, 20:10
-
core-ci voted on patch set 6 V +1 08/23/21, 20:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15463
-
Christian Kuhn voted on patch set 6 V +1 CR +1 08/23/21, 20:29
-
Andreas Kienast voted on patch set 6 V +2 CR +2 08/23/21, 20:29
-
Andreas Kienast merged patch set 7 08/23/21, 20:29