Review main Merged

70684[BUGFIX] Reactivate preset actions in current EXT:impexp

Alexander Nitsche CR +2 V +2 Hard +120 −156 updated 08/23/21, 20:29

Commit message

This is a regression introduced with #94772 that causes all actions
related to export presets to fail because the controller checks $_GET
instead of $_POST for incoming preset action parameters.

Reduced redundancy in EXT:impexp acceptance tests by introducing
AbstractCest::selectInContextMenu() for basic context menu handling
and moving waitForAjaxRequestToFinish() to the central AbstractCest.
In addition, the declarations of local variables have been bundled.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1117

  1. Alexander Nitsche uploaded patch set 1 08/19/21, 22:08

  2. core-ci voted on patch set 1 V -1 08/19/21, 22:28 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15314

  3. Alexander Nitsche uploaded patch set 2 08/20/21, 05:02

  4. core-ci voted on patch set 2 V +1 08/20/21, 05:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15319

  5. Alexander Nitsche uploaded patch set 3 08/20/21, 14:52

  6. core-ci voted on patch set 3 V +1 08/20/21, 15:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15328

  7. Alexander Nitsche updated the commit message in patch set 4 08/20/21, 15:20

  8. Alexander Nitsche commented on patch set 4 08/20/21, 15:22

    This patch is only about one line of code where it fetches $_POST instead of $_GET. The remainder is about an according acceptance test and some re-organisation of the EXT:impexp acceptance tests which run still fine.
  9. Alexander Nitsche commented on patch set 4 08/20/21, 15:30

    Perform testing by ### Without this patch Logging into TYPO3 backend > List > Right click on page tree item > More options > Export > Tab "File & Preset" > Insert "MyFirstPreset" in "Title of new preset" > Click button "Save" ==> Confirm that no flash message is shown & confirm that there is no preset "MyFirstPreset" available in "Select preset" ### With this patch Same steps in browser as for section "Without this patch" ==> Confirm that a flash message is shown & confirm that there is a preset "MyFirstPreset" available in "Select preset"
  10. core-ci voted on patch set 4 V +1 08/20/21, 15:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15333

  11. Alexander Nitsche updated the commit message in patch set 5 08/20/21, 17:25

  12. core-ci voted on patch set 5 V +1 08/20/21, 17:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15340

  13. Christian Kuhn uploaded patch set 6 08/23/21, 20:10

  14. core-ci voted on patch set 6 V +1 08/23/21, 20:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15463

  15. Christian Kuhn voted on patch set 6 V +1 CR +1 08/23/21, 20:29

  16. Andreas Kienast voted on patch set 6 V +2 CR +2 08/23/21, 20:29

  17. Andreas Kienast merged patch set 7 08/23/21, 20:29