70688[FEATURE] Add keyboard shortcuts for multi record selection
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Mathias Brodala +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 3
Review log 2734
Show 79 earlier messages
-
Oli Bartsch uploaded patch set 1 08/20/21, 15:20
-
Oli Bartsch updated the commit message in patch set 2 08/20/21, 15:24
-
Mathias Brodala commented on patch set 2 08/20/21, 15:26
This should be "ctrl" instead. -
core-ci voted on patch set 1 V +1 08/20/21, 15:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15334
-
core-ci voted on patch set 2 V +1 08/20/21, 15:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15335
-
Oli Bartsch commented on patch set 2 08/20/21, 15:55
Reply
You mean you would like to have this on the crtl key? Current implementation is "alt" / "option" key. -
Mathias Brodala commented on patch set 2 08/20/21, 15:57
Reply
I mean toggling/inverting the clicked selection item is done with the Ctrl key on Windows/Linux systems. The alt key is not used in selection handling. -
Oli Bartsch commented on patch set 2 08/20/21, 16:04
Reply
Not sure, ctrl opens the context menu on mac. So this can not be used. -
Mathias Brodala commented on patch set 2 08/20/21, 16:06
Reply
Hm, then we need an OS switch here I'm afraid. E.g. I cannot use the Alt key since that would start a window move in my window manager (Xfwm4) And as mentioned, every application on Windows/Linux uses Ctrl for this.
-
Simon Schaufelberger commented on patch set 2 V +1 CR +1 08/20/21, 16:09
Tested in Chrome on Ubuntu and worked well -
Oli Bartsch uploaded patch set 3 08/20/21, 16:16
-
Oli Bartsch commented on patch set 3 08/20/21, 16:21
Reply
Updated the patch, could you please test again?Reply
I added the "ctrl" so this can now be used, too. I don't think we need an os switch here. This way users can just use what's available for them as the javascript will not override the os specific shortcut as we recently learned :) -
Simon Schaufelberger voted on patch set 3 V +1 CR +1 08/20/21, 16:32
-
core-ci voted on patch set 3 V +1 08/20/21, 16:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15337
-
Jochen Roth updated the commit message in patch set 4 08/20/21, 18:28
-
core-ci voted on patch set 4 V +1 08/20/21, 18:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15343
-
Jochen Roth voted on patch set 4 V +1 CR +1 08/20/21, 19:44
-
Oli Bartsch uploaded patch set 5 08/20/21, 20:04
-
core-ci voted on patch set 5 V +1 08/20/21, 20:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15351
-
Jochen Roth voted on patch set 5 V +1 CR +1 08/20/21, 21:28
-
Simon Schaufelberger commented on patch set 5 08/21/21, 12:49
Please fix this small typoMultiRecordSelection.ts:280delete "is" -
Oli Bartsch uploaded patch set 6 08/23/21, 09:02
-
Oli Bartsch commented on patch set 6 08/23/21, 09:03
Reply
DoneMultiRecordSelection.ts:280ReplyDone -
Jochen Roth voted on patch set 6 V +1 CR +1 08/23/21, 09:05
-
core-ci voted on patch set 6 V +1 08/23/21, 09:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15405
-
Oli Bartsch uploaded patch set 7 08/23/21, 11:38
-
core-ci voted on patch set 7 V +1 08/23/21, 11:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15410
-
Oli Bartsch commented on patch set 7 08/23/21, 15:17
Just resolved merge conflicts. -
Benni Mack commented on patch set 7 V +1 CR +1 08/23/21, 16:11
Great improvement. @mbrodala: Does this patch work for you? -
Jochen Roth voted on patch set 7 V +1 CR +1 08/24/21, 10:45
-
Mathias Brodala commented on patch set 7 V +1 08/24/21, 10:51
Yes, works for me; I can invert the state of all checkboxes just fine with this. -
Oli Bartsch commented on patch set 7 V +2 CR +2 08/24/21, 11:01
Reply
Thanks for testing. -
Oli Bartsch commented on patch set 7 08/24/21, 11:02
Reply
Done -
Oli Bartsch merged patch set 8 08/24/21, 11:02