Review main Merged

70688[FEATURE] Add keyboard shortcuts for multi record selection

Oli Bartsch CR +2 V +2 Normal +79 −1 updated 08/24/21, 11:02

Commit message

The multi record selection, introduced in #94906,
is extended for keyboard shortcuts. They can be
used to achieve similar results as by using the
actions in the multi record selection dropdown.

* `shift` key: check / uncheck the range between the
  last checked checkbox and the current one

* `option` (Mac) or `ctrl` (Windows/Linux) key: Toggle
  the current selection

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Mathias Brodala +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 2734

Show 79 earlier messages
  1. Oli Bartsch uploaded patch set 1 08/20/21, 15:20

  2. Oli Bartsch updated the commit message in patch set 2 08/20/21, 15:24

  3. Mathias Brodala commented on patch set 2 08/20/21, 15:26

    This should be "ctrl" instead.
  4. core-ci voted on patch set 1 V +1 08/20/21, 15:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15334

  5. core-ci voted on patch set 2 V +1 08/20/21, 15:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15335

  6. Oli Bartsch commented on patch set 2 08/20/21, 15:55

    Reply

    You mean you would like to have this on the crtl key? Current implementation is "alt" / "option" key.
  7. Mathias Brodala commented on patch set 2 08/20/21, 15:57

    Reply

    I mean toggling/inverting the clicked selection item is done with the Ctrl key on Windows/Linux systems. The alt key is not used in selection handling.
  8. Oli Bartsch commented on patch set 2 08/20/21, 16:04

    Reply

    Not sure, ctrl opens the context menu on mac. So this can not be used.
  9. Mathias Brodala commented on patch set 2 08/20/21, 16:06

    Reply

    Hm, then we need an OS switch here I'm afraid. E.g. I cannot use the Alt key since that would start a window move in my window manager (Xfwm4) And as mentioned, every application on Windows/Linux uses Ctrl for this.
  1. Simon Schaufelberger commented on patch set 2 V +1 CR +1 08/20/21, 16:09

    Tested in Chrome on Ubuntu and worked well
  2. Oli Bartsch uploaded patch set 3 08/20/21, 16:16

  3. Oli Bartsch commented on patch set 3 08/20/21, 16:21

    Reply

    Updated the patch, could you please test again?

    Reply

    I added the "ctrl" so this can now be used, too. I don't think we need an os switch here. This way users can just use what's available for them as the javascript will not override the os specific shortcut as we recently learned :)
  4. Simon Schaufelberger voted on patch set 3 V +1 CR +1 08/20/21, 16:32

  5. core-ci voted on patch set 3 V +1 08/20/21, 16:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15337

  6. Jochen Roth updated the commit message in patch set 4 08/20/21, 18:28

  7. core-ci voted on patch set 4 V +1 08/20/21, 18:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15343

  8. Jochen Roth voted on patch set 4 V +1 CR +1 08/20/21, 19:44

  9. Oli Bartsch uploaded patch set 5 08/20/21, 20:04

  10. core-ci voted on patch set 5 V +1 08/20/21, 20:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15351

  11. Jochen Roth voted on patch set 5 V +1 CR +1 08/20/21, 21:28

  12. Simon Schaufelberger commented on patch set 5 08/21/21, 12:49

    Please fix this small typo

    MultiRecordSelection.ts:280

    delete "is"
  13. Oli Bartsch uploaded patch set 6 08/23/21, 09:02

  14. Oli Bartsch commented on patch set 6 08/23/21, 09:03

    Reply

    Done

    MultiRecordSelection.ts:280 Reply

    Done
  15. Jochen Roth voted on patch set 6 V +1 CR +1 08/23/21, 09:05

  16. core-ci voted on patch set 6 V +1 08/23/21, 09:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15405

  17. Oli Bartsch uploaded patch set 7 08/23/21, 11:38

  18. core-ci voted on patch set 7 V +1 08/23/21, 11:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15410

  19. Oli Bartsch commented on patch set 7 08/23/21, 15:17

    Just resolved merge conflicts.
  20. Benni Mack commented on patch set 7 V +1 CR +1 08/23/21, 16:11

    Great improvement. @mbrodala: Does this patch work for you?
  21. Jochen Roth voted on patch set 7 V +1 CR +1 08/24/21, 10:45

  22. Mathias Brodala commented on patch set 7 V +1 08/24/21, 10:51

    Yes, works for me; I can invert the state of all checkboxes just fine with this.
  23. Oli Bartsch commented on patch set 7 V +2 CR +2 08/24/21, 11:01

    Reply

    Thanks for testing.
  24. Oli Bartsch commented on patch set 7 08/24/21, 11:02

    Reply

    Done
  25. Oli Bartsch merged patch set 8 08/24/21, 11:02