70690[BUGFIX] Re-enable reset of excluded records in EXT:impexp
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Andreas Kienast +1
- Alexander Nitsche +1
-
Verified V +2 Done
- Christian Kuhn +2
- Andreas Kienast +1
- Alexander Nitsche +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1216
-
Alexander Nitsche uploaded patch set 1 08/20/21, 19:59
-
core-ci voted on patch set 1 V +1 08/20/21, 20:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15350
-
Alexander Nitsche uploaded patch set 2 08/21/21, 08:22
-
core-ci voted on patch set 2 V +1 08/21/21, 08:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15365
-
Alexander Nitsche updated the commit message in patch set 3 08/21/21, 08:53
-
Alexander Nitsche commented on patch set 3 08/21/21, 09:02
Perform testing by ### Without this patch Logging into TYPO3 backend > List > Right click on page tree item > More options > Export > Check "Exclude" of one record > Click button "Update" > Check "Clear all manual exclusions" > Click button "Update" ==> Confirm that an exception is thrown ### With this patch Same steps in browser as for section "Without this patch" ==> Confirm that no records are excluded anymore -
core-ci voted on patch set 3 V +1 08/21/21, 09:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15366
-
Andreas Kienast commented on patch set 3 08/23/21, 20:11
ExportController.php:132PhpStorm annotates this with "Unnecessary cast to '(bool)($inData['resetExclude'] ?? false)'" -
Alexander Nitsche commented on patch set 3 08/23/21, 20:19
ExportController.php:132ReplyYes, i did not understand that comment, to be honest. The same casting is done some lines below with the same "unknown" array. -
Andreas Kienast commented on patch set 3 08/23/21, 20:26
ExportController.php:132Reply UnresolvedEasy: since it's a simple condition, PHP is totally fine with getting any value here, as condition expressions must not be necessarily bools, hence the "unnecessary bool" hint. -
Andreas Kienast commented on patch set 4 08/23/21, 20:32
Published edit on patch set 3. -
Andreas Kienast voted on patch set 4 V +1 CR +1 08/23/21, 20:33
-
Alexander Nitsche voted on patch set 4 V +1 CR +1 08/23/21, 20:34
-
core-ci voted on patch set 4 V +1 08/23/21, 20:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15465
-
Christian Kuhn voted on patch set 4 V +2 CR +2 08/23/21, 21:08
-
Christian Kuhn merged patch set 5 08/23/21, 21:08