Review main Merged

70690[BUGFIX] Re-enable reset of excluded records in EXT:impexp

Alexander Nitsche CR +2 V +2 Easy +44 −4 updated 08/23/21, 21:08

Commit message

This is a regression introduced with #94057 that causes resetting
excluded records to throw an exception in the export view, since the
incoming parameter "exclude" could be of type array (= add excluded
records) or integer (= include all records again), but was only
checked for null or not null, which was ambiguous in the second case.
For clear separation the reset of excluded records is now done via a
new parameter "resetExclude".

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Alexander Nitsche +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Alexander Nitsche +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1216

  1. Alexander Nitsche uploaded patch set 1 08/20/21, 19:59

  2. core-ci voted on patch set 1 V +1 08/20/21, 20:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15350

  3. Alexander Nitsche uploaded patch set 2 08/21/21, 08:22

  4. core-ci voted on patch set 2 V +1 08/21/21, 08:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15365

  5. Alexander Nitsche updated the commit message in patch set 3 08/21/21, 08:53

  6. Alexander Nitsche commented on patch set 3 08/21/21, 09:02

    Perform testing by ### Without this patch Logging into TYPO3 backend > List > Right click on page tree item > More options > Export > Check "Exclude" of one record > Click button "Update" > Check "Clear all manual exclusions" > Click button "Update" ==> Confirm that an exception is thrown ### With this patch Same steps in browser as for section "Without this patch" ==> Confirm that no records are excluded anymore
  7. core-ci voted on patch set 3 V +1 08/21/21, 09:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15366

  8. Andreas Kienast commented on patch set 3 08/23/21, 20:11

    ExportController.php:132

    PhpStorm annotates this with "Unnecessary cast to '(bool)($inData['resetExclude'] ?? false)'"
  9. Alexander Nitsche commented on patch set 3 08/23/21, 20:19

    ExportController.php:132 Reply

    Yes, i did not understand that comment, to be honest. The same casting is done some lines below with the same "unknown" array.
  10. Andreas Kienast commented on patch set 3 08/23/21, 20:26

    ExportController.php:132 Reply Unresolved

    Easy: since it's a simple condition, PHP is totally fine with getting any value here, as condition expressions must not be necessarily bools, hence the "unnecessary bool" hint.
  11. Andreas Kienast commented on patch set 4 08/23/21, 20:32

    Published edit on patch set 3.
  12. Andreas Kienast voted on patch set 4 V +1 CR +1 08/23/21, 20:33

  13. Alexander Nitsche voted on patch set 4 V +1 CR +1 08/23/21, 20:34

  14. core-ci voted on patch set 4 V +1 08/23/21, 20:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15465

  15. Christian Kuhn voted on patch set 4 V +2 CR +2 08/23/21, 21:08

  16. Christian Kuhn merged patch set 5 08/23/21, 21:08