Review main Merged

70691[BUGFIX] Reset mass action state when updating workspace listing

Oli Bartsch CR +2 V +2 Easy +23 −5 updated 08/23/21, 18:06

Commit message

Have you ever wondered why "unrelated" records
got processed in workspaces review when using
one of the mass actions?

Simply because the workspace JavaScript component
is using an internal array, holding all selected records.
This internal array however was only reset on leaving
the module.

Therefore, all records which had been selected since
the module was accessed were taken into account
when a mass action was executed. This did not only
affect records which were unchecked prior to mass
action execution, but also records which were no
longer visible at this time, e.g. due to an applied
filter. In the worst case, that led to completely
unrelated records got published to a live workspace.

This is now fixed by resetting the mass action state
whenever the listing gets updated. This way, only
the selected records in the current view are taken
into account when executing a mass action.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1014

  1. Oli Bartsch uploaded patch set 1 08/20/21, 21:38

  2. Oli Bartsch updated the commit message in patch set 2 08/20/21, 21:40

  3. Oli Bartsch uploaded patch set 3 08/20/21, 21:53

  4. core-ci voted on patch set 2 V +1 08/20/21, 21:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15356

  5. core-ci voted on patch set 1 V +1 08/20/21, 22:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15355

  6. core-ci voted on patch set 3 V +1 08/20/21, 22:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15357

  7. Benni Mack voted on patch set 3 V +1 CR +1 08/23/21, 08:39

  8. Oli Bartsch uploaded patch set 4 08/23/21, 15:16

  9. core-ci voted on patch set 4 V +1 08/23/21, 15:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15416

  10. Benni Mack voted on patch set 4 V +1 CR +1 08/23/21, 16:32

  11. Anja Leichsenring voted on patch set 4 V +1 08/23/21, 16:45

  12. Wouter Wolters voted on patch set 4 V +1 CR +1 08/23/21, 17:56

  13. Oli Bartsch voted on patch set 4 V +2 CR +2 08/23/21, 18:06

  14. Oli Bartsch merged patch set 5 08/23/21, 18:06