Review main Merged

70694[BUGFIX] Revert "Remove prefixed scriptName from urlPath in PageRouter"

Benni Mack CR +2 V +2 Easy +2 −27 updated 08/23/21, 20:02

Commit message

This reverts commit e2e59fb3db537bc7b2c0baa00267edfdd415035c due
to certain incompatibilities with direct "index.php" calls in
certain server setups.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. Benni Mack uploaded patch set 1 08/23/21, 18:31

  2. Andreas Kienast updated the commit message in patch set 2 08/23/21, 18:32

  3. core-ci voted on patch set 2 V +1 08/23/21, 18:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15445

  4. Andreas Kienast voted on patch set 2 V +1 CR +1 08/23/21, 18:52

  5. core-ci voted on patch set 1 V +1 08/23/21, 18:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15444

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 08/23/21, 19:16

  7. Benni Mack voted on patch set 2 V +2 CR +2 08/23/21, 20:02

  8. Benni Mack merged patch set 3 08/23/21, 20:02