Review main Merged

7071[BUGFIX] Page within a mountpoint using Show Content from Page results in 503 header

Patrick Broens CR +2 V +2 Easy +1 −0 updated 06/03/13, 20:49

Commit message

When pages:content_from_pid is used, the TSFE for the current object will be cloned to a temporary object for the page to get the content from. In this temporary object, the id for the page will be changed to the contents of content_from_pid. However, the MP variable will not be changed.

This results in a TSFE object with the wrong MP variable connected to the id. Within this temporary object the rootline will be calculated, which will be empty, because of the wrong MP variable. This triggers the 503 header.

This bugfix fixes this by emptying the MP variable.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Stefan Neufeind +1
  • Verified V +2
    • Steffen Ritter +2
    • Stefan Neufeind +1

Files 1

Review log 8

  1. Stefan Neufeind commented on patch set 1 V 0 03/07/12, 20:30

    please break long lines
    needs 4.8 as well
  2. Stefan Neufeind commented on patch set 1 1 comment 03/07/12, 20:30

    Looks good to me, but someone else must approve together with explanation imho this makes sense by reading
  3. Steffen Ritter commented on patch set 1 03/07/12, 20:30

    Looks good to me, but someone else must approve
  4. Steffen Ritter commented on patch set 1 03/07/12, 20:30

    Verified; Looks good to me, approved
  5. Steffen Ritter commented on patch set 1 V 0 03/07/12, 20:30

    by team member
  6. Steffen Ritter merged patch set 1 03/07/12, 20:30

  7. Mr. Jenkins commented on patch set 1 03/07/12, 20:30

  8. Stefan Neufeind commented on patch set 1 03/07/12, 20:30

    (1 inline comment)