Review main Merged

70712[BUGFIX] Keep checked state of record relations in sync

Oli Bartsch CR +2 V +2 Normal +60 −2 updated 08/24/21, 11:14

Commit message

The workspace review features the collapse/expand
functionality for record relations. An example is tt_content
which may contain several sys_file_reference relations.
They are included in the listing as well but collapsed by
default.

Since at least v10 those relations are always processed
together. This means, in case an editor checks a parent
record and executes an action, e.g. publish, the same
action is also executed for the relations. However,
the UX was previously not really helpful as this was
not visible to the editor.

Therefore, and to improve the UX in workspace review,
those relations are now always "bound together". This
means, when selecting the parent record all relations
are selected, too. The same goes the other way round.
When selecting a relation, all corresponding relations
as well as the parent record are selected.

As mentioned, this does not change any functionality as
this process was already done "under the hood". This
process is now just visualized for the editor.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1822

  1. Oli Bartsch uploaded patch set 1 08/21/21, 00:19

  2. Oli Bartsch updated the commit message in patch set 2 08/21/21, 00:21

  3. core-ci voted on patch set 1 V +1 08/21/21, 00:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15358

  4. core-ci voted on patch set 2 V +1 08/21/21, 00:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15359

  5. Oli Bartsch commented on patch set 2 08/21/21, 00:54

    Multi record selection "Toggle All" feature requires https://review.typo3.org/c/Packages/TYPO3.CMS/+/70713 to work correctly since workspace now changes checkbox state manually.
  6. Jochen Roth voted on patch set 2 V +1 CR +1 08/23/21, 06:54

  7. Benni Mack voted on patch set 2 V +1 CR +1 08/23/21, 08:22

  8. Rachel Foucard commented on patch set 2 08/23/21, 10:13

    Hi, why not just removing the useless checkboxes if it's not possible to check/uncheck them individualy? If you really want to keep them and automatically check/uncheck them, it may be necessary to add aria-live attributes for accessibility (to be confirmed by accessibility team).
  9. Benni Mack commented on patch set 2 08/23/21, 11:59

    Reply

    Hey Rachel, one can e.g. select a child element (sys_file_reference) and discard it, so it is possible to only select a child element, however, when selecting the parent, the child elements are discarded / published along, and therefore automatically selected. So the checkbox makes sense to stick around IMHO.
  10. Rachel Foucard commented on patch set 2 08/23/21, 13:23

    Reply

    Hi Benni, thank you for the explanation. When I test this patch, if I check/uncheck a children, it check/uncheck also the parent and the "brothers" so I don't see how we can publish or discard a child independently now?
  11. Oli Bartsch commented on patch set 2 08/23/21, 14:16

    Reply

    The main reasons for keeping the checkboxes is that this patch is declared as bugfix and will be backported to v10. Therefore, the patch must be kept simple and should not change appearance. Also editors will better understand the connection if the "auto check" works in both directions.
  12. Oli Bartsch uploaded patch set 3 08/23/21, 15:14

  13. core-ci voted on patch set 3 V +1 08/23/21, 15:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15415

  14. Rachel Foucard commented on patch set 3 08/23/21, 15:57

    Reply

    Ack
  15. Benni Mack voted on patch set 3 V +1 CR +1 08/23/21, 16:32

  16. Anja Leichsenring voted on patch set 3 V +1 08/23/21, 16:47

  17. Oli Bartsch uploaded patch set 4 08/23/21, 18:19

  18. core-ci voted on patch set 4 V +1 08/23/21, 18:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15441

  19. Benni Mack voted on patch set 4 V +1 CR +1 08/23/21, 19:25

  20. Jochen Roth voted on patch set 4 V +1 CR +1 08/24/21, 10:44

  21. Oli Bartsch commented on patch set 4 V +2 CR +2 08/24/21, 11:14

    R
  22. Oli Bartsch merged patch set 5 08/24/21, 11:14