Review main Merged

70713[TASK] Allow components to manually change checkbox state

Oli Bartsch CR +2 V +2 Easy +26 −3 updated 08/23/21, 10:43

Commit message

Components, using the multi record selection,
introduced in #94906, usually do not have to
change any checkbox state manually. The multi
record selection component is taking care of it.

However, there might be cases when a consuming
component needs to change checkbox state on its
own. An example is the workspaces module, which
may changes checkbox state of child records when
their parent record got changed. See: #94404.

To prevent the components from overriding each
other, the multi record selection now respects
a special data attribute `manually-changed`.
If set on a checkbox element, the multi record
selection component will not touch this checkbox,
while executing its (mass) actions.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Oli Bartsch uploaded patch set 1 08/21/21, 00:43

  2. Oli Bartsch updated the commit message in patch set 2 08/21/21, 00:46

  3. core-ci voted on patch set 1 V +1 08/21/21, 01:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15360

  4. core-ci voted on patch set 2 V +1 08/21/21, 01:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15361

  5. Jochen Roth voted on patch set 2 V +1 CR +1 08/23/21, 06:54

  6. Benni Mack voted on patch set 2 V +2 CR +2 08/23/21, 10:43

  7. Benni Mack merged patch set 3 08/23/21, 10:43