Review main Merged

70714[TASK] Deprecate edit panel related functionality

Christian Kuhn CR +2 V +2 Hard +385 −327 updated 08/23/21, 19:27

Commit message

The frontend editing extension ext:feedit has been
extracted from core monorepo with #87498 in v10.

This rendered stdWrap.editPanel, stdWrap.editIcons
and EDITPANEL content object unused as core
functionality.

The patch deprecates these parts: Extensions that
rely on it - typically ext:feedit and
ext:frontend_editing should integrate stdWrap
using hooks and registering an own EDITPANEL cObj
if needed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 37

Show 17 more files

Review log 1318

  1. Christian Kuhn uploaded patch set 1 08/21/21, 10:05

  2. core-ci voted on patch set 1 V +1 08/21/21, 10:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15367

  3. Christian Kuhn uploaded patch set 2 08/21/21, 11:13

  4. core-ci voted on patch set 2 V +1 08/21/21, 11:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15368

  5. Benni Mack voted on patch set 2 V +1 CR +1 08/23/21, 15:07

  6. Anja Leichsenring commented on patch set 3 08/23/21, 18:39

    Published edit on patch set 2.
  7. Andreas Kienast commented on patch set 3 CR -1 08/23/21, 18:41

    on it, will rebase as well
  8. Andreas Kienast uploaded patch set 4 08/23/21, 18:47

  9. Andreas Kienast commented on patch set 4 CR -1 08/23/21, 18:49

    on it

    MethodCallMatcher.php:4854

    wrong class name
  10. Andreas Kienast uploaded patch set 5 08/23/21, 18:52

  11. Andreas Kienast voted on patch set 5 V +1 CR +1 08/23/21, 18:52

  12. Anja Leichsenring voted on patch set 5 V +1 CR +1 08/23/21, 18:54

  13. core-ci voted on patch set 4 V +1 08/23/21, 19:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15448

  14. core-ci voted on patch set 3 V +1 08/23/21, 19:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15447

  15. core-ci voted on patch set 5 V +1 08/23/21, 19:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15449

  16. Christian Kuhn voted on patch set 5 V +2 CR +2 08/23/21, 19:26

  17. Christian Kuhn commented on patch set 5 08/23/21, 19:27

    MethodCallMatcher.php:4854 Reply

    Done
  18. Christian Kuhn merged patch set 6 08/23/21, 19:27