Review main Merged

70717[TASK] Explicitly set ContentObjectRenderer in USER cObj

Christian Kuhn CR +2 V +2 Normal +157 −10 updated 08/23/21, 17:52

Commit message

Handing around ContentObjectRenderer in the frontend
is tricky and intransparent. Especially class instances
created via ContentObjectRenderer->callUserFunction()
get an instance of it set through public property $cObj
in the consuming class. This is typically the case for
USER and USER_INT type frontend plugins.

The patch deprecates using this public property and
calls the method setContentObjectRenderer() instead.

This explicit method call is much easier to see,
break point and follow. The state handling of
ContentObjectRenderer is far from obvious, the
change helps debugging and refactoring this further.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 914

  1. Christian Kuhn uploaded patch set 1 08/22/21, 09:53

  2. Christian Kuhn uploaded patch set 2 08/22/21, 10:11

  3. core-ci voted on patch set 1 V +1 08/22/21, 10:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15379

  4. core-ci voted on patch set 2 V -1 08/22/21, 10:14 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15380

  5. Christian Kuhn uploaded patch set 3 08/22/21, 10:23

  6. core-ci voted on patch set 3 V +1 08/22/21, 10:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15381

  7. Christian Kuhn uploaded patch set 4 08/22/21, 11:54

  8. core-ci voted on patch set 4 V +1 08/22/21, 12:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15383

  9. Benni Mack voted on patch set 4 V +1 CR +1 08/23/21, 15:07

  10. Anja Leichsenring commented on patch set 5 08/23/21, 17:29

    Published edit on patch set 4.
  11. Anja Leichsenring voted on patch set 5 V +1 CR +1 08/23/21, 17:36

  12. core-ci voted on patch set 5 V +1 08/23/21, 17:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15430

  13. Benni Mack voted on patch set 5 V +2 CR +2 08/23/21, 17:52

  14. Benni Mack merged patch set 6 08/23/21, 17:52