Review main Merged

70718[BUGFIX] Correct decision about new content button

Claus Due CR +2 V +2 Easy +9 −6 updated 09/09/21, 12:42

Commit message

This patch fixes an issue with mod.web_layout.defLangBinding = 1
which when enabled would cause the page layout module to
render the "new content" buttons when this was not desired.

The fixes consist of:

* A change to make sure that Fluid variable {column} contains
  the right language ID in the PageLayoutContext associated
  with the column; by re-assigning {column} within the loop
  over {languageColumns} in LanguageColumns.html
* Re-overwriting the {column} variable after the loop to ensure
  it holds the default language column which holds the default
  language column's content records that are iterated over.
* Overwriting the {column} variable within the loop that renders
  each content record to ensure it holds the correct language ID
  in the column's PageLayoutContext.
* Assigning the right PageLayoutContext to translated versions
  of content records to ensure that the "new content" button
  below each translated content element points to the right
  language UID.
* A visual alignment fix setting valign="top" on TD elements
  to ensure the alignment of each content record and the
  column header, when the "new content" button is not shown.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1217

  1. Claus Due uploaded patch set 1 08/22/21, 12:43

  2. core-ci voted on patch set 1 V +1 08/22/21, 13:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15385

  3. Claus Due uploaded patch set 2 08/22/21, 13:12

  4. core-ci voted on patch set 2 V -1 08/22/21, 13:36 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15387

  5. core-ci commented on patch set 2 08/22/21, 16:42 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15387

  6. Anja Leichsenring commented on patch set 2 V -1 08/30/21, 06:37

    the upper button is gone now, but below any translated CE, the add button is still there and works as expected, leading to mixed mode. This is, even with allowInconsistentLanguageHandling = 0 in place.
  7. Claus Due uploaded patch set 3 09/03/21, 08:38

  8. Claus Due uploaded patch set 4 09/03/21, 08:44

  9. core-ci voted on patch set 3 V +1 09/03/21, 08:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16155

  10. core-ci voted on patch set 4 V +1 09/03/21, 09:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16156

  11. Anja Leichsenring voted on patch set 4 V +1 CR +1 09/03/21, 09:30

  12. Jonas Eberle commented on patch set 4 09/03/21, 12:29

    LanguageColumns.html:71

    <td valign> can be considered deprecated. Rather use CSS `vertical-align`
  13. Claus Due commented on patch set 4 09/03/21, 12:58

    LanguageColumns.html:71 Reply

    This was copied from elsewhere in the PageLayout templates, whose markup was in turn copied from the old PageLayoutView. Although I agree this should be CSS, I definitely don't agree that it should be done within this merge request. It should be done for all of the templates as a separate merge request.
  14. Oli Bartsch voted on patch set 4 V +1 CR +1 09/09/21, 10:19

  15. Jonas Eberle commented on patch set 4 09/09/21, 10:22

    LanguageColumns.html:71 Reply

    Ack
  16. Georg Ringer voted on patch set 4 V +2 CR +2 09/09/21, 12:14

  17. Georg Ringer merged patch set 5 09/09/21, 12:42