70718[BUGFIX] Correct decision about new content button
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1217
-
Claus Due uploaded patch set 1 08/22/21, 12:43
-
core-ci voted on patch set 1 V +1 08/22/21, 13:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15385
-
Claus Due uploaded patch set 2 08/22/21, 13:12
-
core-ci voted on patch set 2 V -1 08/22/21, 13:36 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15387
-
core-ci commented on patch set 2 08/22/21, 16:42 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15387
-
Anja Leichsenring commented on patch set 2 V -1 08/30/21, 06:37
the upper button is gone now, but below any translated CE, the add button is still there and works as expected, leading to mixed mode. This is, even with allowInconsistentLanguageHandling = 0 in place. -
Claus Due uploaded patch set 3 09/03/21, 08:38
-
Claus Due uploaded patch set 4 09/03/21, 08:44
-
core-ci voted on patch set 3 V +1 09/03/21, 08:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16155
-
core-ci voted on patch set 4 V +1 09/03/21, 09:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16156
-
Anja Leichsenring voted on patch set 4 V +1 CR +1 09/03/21, 09:30
-
Jonas Eberle commented on patch set 4 09/03/21, 12:29
LanguageColumns.html:71<td valign> can be considered deprecated. Rather use CSS `vertical-align` -
Claus Due commented on patch set 4 09/03/21, 12:58
LanguageColumns.html:71ReplyThis was copied from elsewhere in the PageLayout templates, whose markup was in turn copied from the old PageLayoutView. Although I agree this should be CSS, I definitely don't agree that it should be done within this merge request. It should be done for all of the templates as a separate merge request. -
Oli Bartsch voted on patch set 4 V +1 CR +1 09/09/21, 10:19
-
Jonas Eberle commented on patch set 4 09/09/21, 10:22
LanguageColumns.html:71ReplyAck -
Georg Ringer voted on patch set 4 V +2 CR +2 09/09/21, 12:14
-
Georg Ringer merged patch set 5 09/09/21, 12:42