Review main Merged

70719[TASK] Deprecate TypoScriptFrontendController->cObjectDepthCounter

Christian Kuhn CR +2 V +2 Normal +74 −37 updated 08/23/21, 18:40

Commit message

TypoScriptFrontendController has a property to count nesting
of content objects. This is used in ContentObjectRenderer
to prevent recursion scenarios. If that kicks in, the rendering
is silently stopped.

This is ugly for various reasons: First, creating a recursion
via TypoScript is rather unlikely. Second, the property creates
a dependency between ContentObjectRenderer and
TypoScriptFrontendController. And most importantly: If a
TypoScript setup somehow manages to create a recursion, this
should create an error, not a silent suppression.

The patch drops handling of property cObjectDepthCounter. If
a recursion appears now, PHP will error out as soon as max
nesting level is reached. This obsoletes the property and its
handling.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1115

  1. Christian Kuhn uploaded patch set 1 08/22/21, 13:10

  2. Christian Kuhn updated the commit message in patch set 2 08/22/21, 13:15

  3. Christian Kuhn uploaded patch set 3 08/22/21, 13:24

  4. core-ci voted on patch set 1 V +1 08/22/21, 13:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15386

  5. core-ci voted on patch set 2 V +1 08/22/21, 13:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15388

  6. core-ci voted on patch set 3 V +1 08/22/21, 13:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15389

  7. Benni Mack voted on patch set 3 V +1 CR +1 08/23/21, 15:07

  8. Wouter Wolters voted on patch set 3 V +1 CR +1 08/23/21, 17:54

  9. Christian Kuhn uploaded patch set 4 08/23/21, 18:24

  10. Wouter Wolters voted on patch set 4 V +1 CR +1 08/23/21, 18:25

  11. Anja Leichsenring voted on patch set 4 V +1 CR +1 08/23/21, 18:26

  12. Benni Mack voted on patch set 4 V +1 CR +1 08/23/21, 18:33

  13. core-ci voted on patch set 4 V +1 08/23/21, 18:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15442

  14. Andreas Kienast voted on patch set 4 V +2 CR +2 08/23/21, 18:39

  15. Andreas Kienast merged patch set 5 08/23/21, 18:40