70721[TASK] Deprecate ContentObjectRenderer constructor in StandaloneView
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Jochen Roth +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-94959-ContentObjectRendererConstructorInStandaloneView.rst2new+43 −0
- typo3/sysext/extbase/Classes/Configuration/AbstractConfigurationManager.php+15 −2
- typo3/sysext/extbase/Classes/Configuration/ConfigurationManager.php+1 −2
- typo3/sysext/extbase/Tests/Unit/Configuration/AbstractConfigurationManagerTest.php+4 −2
- typo3/sysext/fluid/Classes/View/StandaloneView.php+5 −3
- typo3/sysext/fluid/Configuration/Services.yaml+4 −0
Review log 1217
-
Christian Kuhn uploaded patch set 1 08/22/21, 15:11
-
core-ci voted on patch set 1 V -1 08/22/21, 15:14 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15391
-
Christian Kuhn uploaded patch set 2 08/22/21, 15:26
-
core-ci voted on patch set 2 V -1 08/22/21, 15:45 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15392
-
Christian Kuhn uploaded patch set 3 08/22/21, 16:09
-
core-ci voted on patch set 3 V -1 08/22/21, 16:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15396
-
Christian Kuhn uploaded patch set 4 08/22/21, 17:17
-
core-ci voted on patch set 4 V +1 08/22/21, 17:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15398
-
Benni Mack commented on patch set 4 08/23/21, 11:39
-
Christian Kuhn commented on patch set 4 CR -1 08/23/21, 12:54
will change some details. -
Christian Kuhn uploaded patch set 5 08/26/21, 06:08
-
Christian Kuhn commented on patch set 5 08/26/21, 06:11
Deprecation-94959-ContentObjectRendererConstructorInStandaloneView.rst:53ReplyGood point. I dropped the deprecation of set/getContentObjectRenderer() from ConfigurationManager from this patch for now. We'll figure something out with a dedicated patch. -
core-ci voted on patch set 5 V +1 08/26/21, 06:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15648
-
Jochen Roth voted on patch set 5 V +1 CR +1 08/26/21, 09:21
-
Oli Bartsch voted on patch set 5 V +1 CR +1 08/26/21, 09:34
-
Christian Kuhn voted on patch set 5 V +2 CR +2 08/26/21, 09:35
-
Christian Kuhn merged patch set 6 08/26/21, 09:36
Deprecation-94959-ContentObjectRendererConstructorInStandaloneView.rst:53