Review main Merged

70724[BUGFIX] Properly check if workspace is accessible

Oli Bartsch CR +2 V +2 Easy +6 −2 updated 08/23/21, 14:44

Commit message

The workspace JavaScript component tries to
fetch the workspace listing on accessing the
backend module. Since #94819 this results in
a JavaScript TypeError since the provided selector
for the progress bar component, used as indicator
for the ajax request, might not exist.

This is now fixed by checking if the the workspace
is actually accessible prior to initiating the ajax call.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 68

  1. Oli Bartsch uploaded patch set 1 08/23/21, 09:57

  2. core-ci voted on patch set 1 V +1 08/23/21, 10:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15407

  3. Benni Mack voted on patch set 1 V +1 CR +1 08/23/21, 10:44

  4. Christian Kuhn updated the commit message in patch set 2 08/23/21, 11:31

  5. core-ci voted on patch set 2 V +1 08/23/21, 11:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15409

  6. Benni Mack voted on patch set 2 V +1 CR +1 08/23/21, 11:58

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 08/23/21, 14:44

  8. Christian Kuhn merged patch set 3 08/23/21, 14:44