70727[FEATURE] Show active debugger in "Application Information"
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Guido Schmechel +1
- crell +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Andreas Kienast +2
- Guido Schmechel +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Classes/Backend/ToolbarItems/SystemInformationToolbarItem.php+16 −0
- typo3/sysext/core/Classes/Imaging/IconRegistry.php+6 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-94966-ShowDebuggerInApplicationInformation.rstnew+23 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+3 −0
Review log 1012
-
Andreas Kienast uploaded patch set 1 08/23/21, 17:37
-
core-ci voted on patch set 1 V +1 08/23/21, 17:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15433
-
Anja Leichsenring commented on patch set 1 V +1 CR +1 08/23/21, 18:07
nice 😊 -
Christian Kuhn commented on patch set 1 08/23/21, 22:07
This claim isn't true as such: With xdebug 3, just having the extension loaded has typically zero performance impact: There are some notes on that by the xdebug team elsewhere, the only impact comes basically from actively loading the module, and this *is* zero with hostings based on php pool provided solutions like fpm. xdebug only impacts performance, if for instance mode "step debugging" is enabled - on cli via env var XDEBUG_MODE="debug", or with the 'cookie' mechanism in web. Other 'modes' may have impact, too, but not as drastically. Simply stating "warning: xdebug=bad for performance" is a rather harsh simplification. -
Andreas Kienast commented on patch set 1 08/24/21, 08:35
Reply Unresolved
I know xdebug 3 has nearly zero impact if installed but no debugging was requested. I simply assume people out there use "old-stable" (😉) software and thus the warning. However, I agree with your statement and will change the patch accordingly. -
Andreas Kienast commented on patch set 2 08/24/21, 11:12
Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 08/24/21, 11:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15492
-
Simon Schaufelberger commented on patch set 2 V +1 CR +1 08/24/21, 19:23
Tested with xdebug and worked -
crell commented on patch set 2 CR +1 08/24/21, 19:31
Code looks fine to me. -
Guido Schmechel voted on patch set 2 V +1 CR +1 08/30/21, 21:41
-
Andreas Kienast voted on patch set 2 V +2 CR +2 09/01/21, 07:23
-
Andreas Kienast merged patch set 3 09/01/21, 07:23