Review main Merged

70731[TASK] Simplify stylesheet and script assignments in ext:form

Oliver Hader CR +2 V +2 Easy +9 −7 updated 08/23/21, 20:35

Commit message

Avoids round trip through Fluid template, but instead assigns
stylesheets and inline scripts directly via `PageRenderer`.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Oliver Hader uploaded patch set 1 08/23/21, 19:35

  2. Andreas Kienast commented on patch set 1 08/23/21, 19:42

    FormEditorController.php:144

    I guess this line is obsolete as well
  3. core-ci voted on patch set 1 V +1 08/23/21, 19:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15458

  4. Oliver Hader commented on patch set 1 08/23/21, 19:59

    FormEditorController.php:144 Reply

    Ack
  5. Oliver Hader uploaded patch set 2 08/23/21, 20:00

  6. Andreas Kienast voted on patch set 2 CR +1 08/23/21, 20:01

  7. core-ci voted on patch set 2 V +1 08/23/21, 20:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15460

  8. Benni Mack voted on patch set 2 V +1 CR +1 08/23/21, 20:31

  9. Andreas Kienast voted on patch set 2 V +2 CR +2 08/23/21, 20:34

  10. Andreas Kienast merged patch set 3 08/23/21, 20:35