Review main Merged

70732[TASK] Avoid calling inline JavaScript jump()

Benni Mack CR +2 V +2 Hard +170 −89 updated 08/27/21, 10:14

Commit message

LiveSearch, Shortcut and OpenDocs call jump()
and thus, uses some "magic" top-level variables
to store the actual URL to go to.

This is not ideal, and the ModuleMenu should resolve
this, preserve the state of the "id" parameter,
open the content frame and (optionally) select a module
which was in use.

The global functions and variables are deprecated now:
* top.currentSubScript
* top.currentModuleLoaded
* top.nextLoadModuleUrl
* jump()

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 24

Show 4 more files

Review log 1321

  1. Benni Mack uploaded patch set 1 08/23/21, 20:02

  2. core-ci voted on patch set 1 V -1 08/23/21, 20:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15461

  3. Benni Mack uploaded patch set 2 08/24/21, 12:11

  4. Benni Mack uploaded patch set 3 08/24/21, 12:37

  5. core-ci voted on patch set 2 V -1 08/24/21, 12:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15502

  6. Oliver Hader voted on patch set 3 CR +1 08/24/21, 12:42

  7. core-ci voted on patch set 3 V -1 08/24/21, 13:06 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15504

  8. Benjamin Franzke uploaded patch set 4 08/26/21, 22:23

  9. core-ci voted on patch set 4 V -1 08/26/21, 22:59 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15693

  10. Benjamin Franzke uploaded patch set 5 08/27/21, 06:46

  11. Benni Mack uploaded patch set 6 08/27/21, 06:54

  12. core-ci voted on patch set 5 V -1 08/27/21, 07:08 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15700

  13. core-ci voted on patch set 6 V -1 08/27/21, 07:12 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15701

  14. Benjamin Franzke uploaded patch set 7 08/27/21, 07:27

  15. core-ci voted on patch set 7 V +1 08/27/21, 07:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15703

  16. Benni Mack uploaded patch set 8 08/27/21, 08:10

  17. core-ci voted on patch set 8 V +1 08/27/21, 08:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15705

  18. Benjamin Franzke voted on patch set 8 V +1 CR +1 08/27/21, 10:02

  19. Oli Bartsch voted on patch set 8 V +1 CR +1 08/27/21, 10:13

  20. Benni Mack voted on patch set 8 V +2 CR +2 08/27/21, 10:14

  21. Benni Mack merged patch set 9 08/27/21, 10:14