Review main Merged

70733[TASK] Remove jQuery.proxy invocation

Oliver Hader CR +2 V +2 Normal +33 −39 updated 08/26/21, 21:01

Commit message

jQuery `$.proxy` invocation was used prior to ES6 times to have
proper `thisArg` scoping in plain JavaScript functions that were
used within jQuery events.

Since arrow functions are used (which keep their local `thisArg` scope),
corresponding `$.proxy` invocations can be removed completely.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Wouter Wolters +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Oliver Hader uploaded patch set 1 08/23/21, 20:28

  2. core-ci voted on patch set 1 V +1 08/23/21, 20:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15464

  3. Wouter Wolters voted on patch set 1 CR +1 08/24/21, 17:36

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 08/24/21, 19:13

  5. Wouter Wolters voted on patch set 1 V +1 08/26/21, 18:29

  6. Oli Bartsch voted on patch set 1 V +1 CR +1 08/26/21, 19:16

  7. Benjamin Franzke voted on patch set 1 V +2 CR +2 08/26/21, 21:01

  8. Benjamin Franzke merged patch set 2 08/26/21, 21:01