70734[TASK] Simplify TemplateView inheritance chain
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Controller/ErrorPageController.php+1 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+5 −4
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ActionControllerTest.php+2 −2
- typo3/sysext/fluid/Classes/View/AbstractTemplateView.php3+2 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/FluidTemplateContentObjectTest.php+8 −6
Review log 912
-
Christian Kuhn uploaded patch set 1 08/24/21, 08:24
-
core-ci voted on patch set 1 V +1 08/24/21, 08:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15477
-
Benni Mack commented on patch set 1 08/24/21, 08:52
-
Christian Kuhn commented on patch set 1 CR -1 08/25/21, 10:37
AbstractTemplateView.php:25Replyagreed. thx. -
Christian Kuhn uploaded patch set 2 08/25/21, 15:10
-
Christian Kuhn commented on patch set 2 08/25/21, 15:11
AbstractTemplateView.php:25ReplyAdapted code here. Usages in those old core version's changelog files shouldn't be adapted. -
Benni Mack voted on patch set 2 V +1 CR +1 08/25/21, 15:12
-
core-ci voted on patch set 2 V -1 08/25/21, 15:25 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15608
-
core-ci voted on patch set 2 V +1 08/25/21, 15:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15608
-
Jochen Roth voted on patch set 2 V +1 CR +1 08/25/21, 15:42
-
Christian Kuhn voted on patch set 2 V +2 CR +2 08/25/21, 15:43
-
Christian Kuhn merged patch set 3 08/25/21, 15:43
AbstractTemplateView.php:25