Review main Merged

70734[TASK] Simplify TemplateView inheritance chain

Christian Kuhn CR +2 V +2 Easy +18 −14 updated 08/25/21, 15:43

Commit message

The fluid view classes have a rather complex inheritance
and dependency chain, especially when looking at the
various extbase related classes, too.

One step is TYPO3Fluid\Fluid\View\TemplateView: This empty
class adds no value, TYPO3\CMS\Fluid\View\AbstractTemplateView
can extend TYPO3Fluid\Fluid\View\AbstractTemplateView instead,
without functional change.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 912

  1. Christian Kuhn uploaded patch set 1 08/24/21, 08:24

  2. core-ci voted on patch set 1 V +1 08/24/21, 08:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15477

  3. Benni Mack commented on patch set 1 08/24/21, 08:52

    AbstractTemplateView.php:25

    TemplateView is also referenced in a few other places (documentation in core), I can point you to the places. I _think_ it would be beneficial to tackle them as well.
  4. Christian Kuhn commented on patch set 1 CR -1 08/25/21, 10:37

    AbstractTemplateView.php:25 Reply

    agreed. thx.
  5. Christian Kuhn uploaded patch set 2 08/25/21, 15:10

  6. Christian Kuhn commented on patch set 2 08/25/21, 15:11

    AbstractTemplateView.php:25 Reply

    Adapted code here. Usages in those old core version's changelog files shouldn't be adapted.
  7. Benni Mack voted on patch set 2 V +1 CR +1 08/25/21, 15:12

  8. core-ci voted on patch set 2 V -1 08/25/21, 15:25 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15608

  9. core-ci voted on patch set 2 V +1 08/25/21, 15:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15608

  10. Jochen Roth voted on patch set 2 V +1 CR +1 08/25/21, 15:42

  11. Christian Kuhn voted on patch set 2 V +2 CR +2 08/25/21, 15:43

  12. Christian Kuhn merged patch set 3 08/25/21, 15:43