70735[TASK] Use native icons for workspace module listings
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Jochen Roth +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/workspaces/Resources/Public/TypeScript/Backend.ts+33 −18
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+2 −2
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+8 −4
- typo3/sysext/workspaces/Resources/Private/Partials/WorkingTable.html+0 −12
- typo3/sysext/workspaces/Resources/Public/JavaScript/Backend.js+1 −1
Review log 1117
-
Benni Mack uploaded patch set 1 08/24/21, 09:12
-
core-ci voted on patch set 1 V +1 08/24/21, 09:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15482
-
Benni Mack uploaded patch set 2 08/24/21, 11:07
-
Benni Mack uploaded patch set 3 08/24/21, 11:20
-
Benni Mack uploaded patch set 4 08/24/21, 11:26
-
core-ci voted on patch set 2 V +1 08/24/21, 11:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15491
-
Benni Mack updated the commit message in patch set 5 08/24/21, 11:32
-
core-ci voted on patch set 3 V +1 08/24/21, 11:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15493
-
core-ci voted on patch set 4 V +1 08/24/21, 11:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15494
-
core-ci voted on patch set 5 V +1 08/24/21, 12:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15495
-
Jochen Roth uploaded patch set 6 08/24/21, 12:07
-
Jochen Roth commented on patch set 6 08/24/21, 12:09
Added a fallback value for PHP8 ``` PHP Warning: Undefined array key "pid" in /var/www/html/typo3/sysext/workspaces/Classes/Service/GridDataService.php line 174 ``` -
core-ci voted on patch set 6 V +1 08/24/21, 12:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15500
-
Oli Bartsch voted on patch set 6 V +1 CR +1 08/24/21, 12:27
-
Jochen Roth voted on patch set 6 V +1 CR +1 08/24/21, 12:37
-
Benni Mack voted on patch set 6 V +2 CR +2 08/24/21, 12:40
-
Benni Mack merged patch set 7 08/24/21, 12:40