Review main Merged

70735[TASK] Use native icons for workspace module listings

Benni Mack CR +2 V +2 Normal +44 −37 updated 08/24/21, 12:40

Commit message

This change uses the native web component to render icons,
instead of referencing them from Fluid.

This change also fixes a small issue regarding language icons
and integrity icons.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1117

  1. Benni Mack uploaded patch set 1 08/24/21, 09:12

  2. core-ci voted on patch set 1 V +1 08/24/21, 09:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15482

  3. Benni Mack uploaded patch set 2 08/24/21, 11:07

  4. Benni Mack uploaded patch set 3 08/24/21, 11:20

  5. Benni Mack uploaded patch set 4 08/24/21, 11:26

  6. core-ci voted on patch set 2 V +1 08/24/21, 11:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15491

  7. Benni Mack updated the commit message in patch set 5 08/24/21, 11:32

  8. core-ci voted on patch set 3 V +1 08/24/21, 11:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15493

  9. core-ci voted on patch set 4 V +1 08/24/21, 11:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15494

  10. core-ci voted on patch set 5 V +1 08/24/21, 12:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15495

  11. Jochen Roth uploaded patch set 6 08/24/21, 12:07

  12. Jochen Roth commented on patch set 6 08/24/21, 12:09

    Added a fallback value for PHP8 ``` PHP Warning: Undefined array key "pid" in /var/www/html/typo3/sysext/workspaces/Classes/Service/GridDataService.php line 174 ```
  13. core-ci voted on patch set 6 V +1 08/24/21, 12:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15500

  14. Oli Bartsch voted on patch set 6 V +1 CR +1 08/24/21, 12:27

  15. Jochen Roth voted on patch set 6 V +1 CR +1 08/24/21, 12:37

  16. Benni Mack voted on patch set 6 V +2 CR +2 08/24/21, 12:40

  17. Benni Mack merged patch set 7 08/24/21, 12:40