Review 10.4 Merged

70737[BUGFIX] Do not transform text when RTE is disabled

Oli Bartsch CR +2 V +2 Normal +142 −14 updated 08/24/21, 11:01

Commit message

The TcaText data provider transforms a given database
field value with the RteHtmlParser as soon as `enableRichtext`
is set for the field in TCA. This means, the data provider
did previously not checked, whether RTE is disabled for the
user in general or for this specific field by configuration
(e.g. page TSconfig). This therefore led, among others, to
"normal" text being falsely wrapped with `<p>` tags.

This is now fixed by checking all relevant settings before
actually transforming the database field value.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Oli Bartsch uploaded patch set 1 08/24/21, 10:45

  2. core-ci voted on patch set 1 V +1 08/24/21, 10:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15489

  3. Oli Bartsch voted on patch set 1 V +2 CR +2 08/24/21, 11:01

  4. Oli Bartsch merged patch set 2 08/24/21, 11:01