Review main Merged

70738[TASK] Remove obsolete LOCK TABLE check from install tool

Frank Nägler CR +2 V +2 Easy +0 −15 updated 08/25/21, 17:55

Commit message

This patch removes the LOCK TABLE permission check from
the PermissionsCheck class that is part of the installer.

TYPO3 Core doesn't need the LOCK TABLE permission, hence
the check can be removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stephan Großberndt +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stephan Großberndt +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1113

  1. Frank Nägler uploaded patch set 1 08/24/21, 11:49

  2. Andreas Kienast updated the commit message in patch set 2 08/24/21, 12:09

  3. Andreas Kienast voted on patch set 2 V +1 CR +1 08/24/21, 12:09

  4. core-ci voted on patch set 1 V -1 08/24/21, 12:13 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15497

  5. core-ci voted on patch set 2 V +1 08/24/21, 12:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15501

  6. Stephan Großberndt commented on patch set 2 08/24/21, 12:34

    I am fine with master keeping that permission requirement (if it actually is - or is going to be - required). It just should not be part of 10.4 (it was added as late as v10.4.9). In former INSTALL.md, added by Morton in 2015 LOCK TABLES was added and later moved to the documentation. So should we keep it for master and remove the check only for 10.4? After merge I will take care of changing the documentation.
  7. Stephan Großberndt voted on patch set 2 CR +1 08/24/21, 19:07

  8. Stephan Großberndt voted on patch set 2 V +1 08/25/21, 12:11

  9. Christian Kuhn commented on patch set 2 V +1 CR +1 08/25/21, 14:14

    Reply

    imho: if neither master nor 10.4 need it *just now*, it should be removed in both versions. if master is later changed and needs it, it can be re-introduced. fine with you?
  10. Stephan Großberndt commented on patch set 2 08/25/21, 14:57

    Yes, fine with me 😊
  11. Jochen Roth voted on patch set 2 V +1 CR +1 08/25/21, 15:46

  12. Christian Kuhn voted on patch set 2 V +2 CR +2 08/25/21, 17:55

  13. Christian Kuhn merged patch set 3 08/25/21, 17:55