Review main Merged

70740[BUGFIX] Allow links in sys_news

Benni Mack CR +2 V +2 Normal +51 −8 updated 09/10/21, 14:28

Commit message

Rendering links set for sys_news (shown at backend
login) records via RTE does not work.

Reason is a nasty dependency to TypoScript
lib.parsefunc, which isn't easy to retrieve
in BE scope.

With recent RTE html parser related changes,
it's now relatively easy to submit a fallback
layer in case for instance f:html view helper
isn't used within FE context.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1216

  1. Benni Mack uploaded patch set 1 08/24/21, 14:05

  2. core-ci voted on patch set 1 V -1 08/24/21, 14:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15514

  3. Christian Kuhn uploaded patch set 2 08/24/21, 16:11

  4. core-ci voted on patch set 2 V -1 08/24/21, 16:28 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15523

  5. Christian Kuhn uploaded patch set 3 08/25/21, 07:57

  6. core-ci voted on patch set 3 V -1 08/25/21, 08:13 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15563

  7. Christian Kuhn uploaded patch set 4 08/25/21, 08:35

  8. core-ci voted on patch set 4 V +1 08/25/21, 08:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15568

  9. Benni Mack voted on patch set 4 V +1 CR +1 08/25/21, 21:57

  10. Christian Kuhn voted on patch set 4 V +1 CR +1 08/26/21, 04:11

  11. Oli Bartsch voted on patch set 4 V +1 CR +1 08/26/21, 09:08

  12. Christian Kuhn voted on patch set 4 V +2 CR +2 08/26/21, 09:08

  13. Christian Kuhn merged patch set 5 08/26/21, 09:08

  14. Oliver Hader commented on patch set 5 09/08/21, 16:50

    Hm... rather -1 to this change as it reintroduces the behavior with html-sanitizer...
  15. Oliver Hader commented on patch set 5 09/08/21, 17:17

    → please see my remarks and suggestions in #95158
  16. Oliver Hader commented on patch set 5 09/10/21, 14:28