70743[TASK] Declare strict types in ext_localconf.php files
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Wouter Wolters +1
-
Verified V +2 Done
- Andreas Kienast +2
- Wouter Wolters +1
- core-ci +1 CI
Issues 2
Files 27
- typo3/sysext/adminpanel/ext_localconf.php+2 −0
- typo3/sysext/backend/ext_localconf.php+2 −0
- typo3/sysext/core/ext_localconf.php+2 −0
- typo3/sysext/dashboard/ext_localconf.php+2 −0
- typo3/sysext/extbase/ext_localconf.php+2 −0
- typo3/sysext/extensionmanager/ext_localconf.php+2 −0
- typo3/sysext/felogin/ext_localconf.php+2 −0
- typo3/sysext/filelist/ext_localconf.php+2 −0
- typo3/sysext/fluid_styled_content/ext_localconf.php+2 −0
- typo3/sysext/form/ext_localconf.php+2 −0
- typo3/sysext/frontend/ext_localconf.php+2 −0
- typo3/sysext/impexp/ext_localconf.php+2 −0
- typo3/sysext/indexed_search/ext_localconf.php+2 −0
- typo3/sysext/install/ext_localconf.php+2 −0
- typo3/sysext/linkvalidator/ext_localconf.php+2 −0
- typo3/sysext/opendocs/ext_localconf.php+2 −0
- typo3/sysext/recordlist/ext_localconf.php+2 −0
- typo3/sysext/recycler/ext_localconf.php+2 −0
- typo3/sysext/redirects/ext_localconf.php+2 −0
- typo3/sysext/reports/ext_localconf.php+2 −0
Show 7 more files
- typo3/sysext/rte_ckeditor/ext_localconf.php+2 −0
- typo3/sysext/scheduler/ext_localconf.php+2 −0
- typo3/sysext/seo/ext_localconf.php+2 −0
- typo3/sysext/sys_note/ext_localconf.php+2 −0
- typo3/sysext/t3editor/ext_localconf.php+2 −0
- typo3/sysext/tstemplate/ext_localconf.php+2 −0
- typo3/sysext/workspaces/ext_localconf.php+2 −0
Review log 911
-
Oli Bartsch uploaded patch set 1 08/24/21, 16:22
-
Simon Gilli commented on patch set 1 08/24/21, 16:25
Do we have an advantage by declaring strict types? They got removed anyway during the creation of the cached file. -
Simon Gilli commented on patch set 1 V +1 CR +1 08/24/21, 16:35
Reply
Answered at Slack: just for the IDE -
Oli Bartsch commented on patch set 1 08/24/21, 16:38
Reply
Yep correct. It's removed on concatenation. However e.g. in PHPstorm without the declaration there is no support on passing wrong types to functions etc. -
core-ci voted on patch set 1 V +1 08/24/21, 16:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15524
-
Wouter Wolters voted on patch set 1 V +1 CR +1 08/24/21, 17:27
-
Andreas Kienast updated the commit message in patch set 2 08/24/21, 19:11
-
core-ci voted on patch set 2 V +1 08/24/21, 19:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15529
-
Wouter Wolters voted on patch set 2 V +1 CR +1 08/24/21, 19:47
-
Andreas Kienast voted on patch set 2 V +2 CR +2 08/24/21, 19:48
-
Andreas Kienast merged patch set 3 08/24/21, 19:48