Review main Merged

70743[TASK] Declare strict types in ext_localconf.php files

Oli Bartsch CR +2 V +2 Normal +54 −0 updated 08/24/21, 19:48

Commit message

Since #94739 it's possible to declare strict types
in ext_localconf.php files. This patch does this
through the core.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 2

Files 27

Review log 911

  1. Oli Bartsch uploaded patch set 1 08/24/21, 16:22

  2. Simon Gilli commented on patch set 1 08/24/21, 16:25

    Do we have an advantage by declaring strict types? They got removed anyway during the creation of the cached file.
  3. Simon Gilli commented on patch set 1 V +1 CR +1 08/24/21, 16:35

    Reply

    Answered at Slack: just for the IDE
  4. Oli Bartsch commented on patch set 1 08/24/21, 16:38

    Reply

    Yep correct. It's removed on concatenation. However e.g. in PHPstorm without the declaration there is no support on passing wrong types to functions etc.
  5. core-ci voted on patch set 1 V +1 08/24/21, 16:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15524

  6. Wouter Wolters voted on patch set 1 V +1 CR +1 08/24/21, 17:27

  7. Andreas Kienast updated the commit message in patch set 2 08/24/21, 19:11

  8. core-ci voted on patch set 2 V +1 08/24/21, 19:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15529

  9. Wouter Wolters voted on patch set 2 V +1 CR +1 08/24/21, 19:47

  10. Andreas Kienast voted on patch set 2 V +2 CR +2 08/24/21, 19:48

  11. Andreas Kienast merged patch set 3 08/24/21, 19:48