70744[TASK] Add ReST file for global namespace scoping
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Simon Gilli +1
- crell +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Simon Gilli +1
- core-ci +1 CI
Issues 2
Files 1
Review log 2228
Show 3 earlier messages
-
Andreas Kienast uploaded patch set 1 08/24/21, 19:08
-
Andreas Kienast uploaded patch set 2 08/24/21, 19:09
-
crell commented on patch set 2 08/24/21, 19:19
Can this also include an example of what one now can/should do in a localconf file? Right now the only example is of what the generated code is. More useful is what I should be writing in my own file(s).
-
Andreas Kienast commented on patch set 2 08/24/21, 19:22
Reply
I thought the last sentence is already properly explaining what we can do here, but sure, I'll update the doc. -
core-ci voted on patch set 1 V +1 08/24/21, 19:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15527
-
Andreas Kienast uploaded patch set 3 08/24/21, 19:27
-
core-ci voted on patch set 2 V +1 08/24/21, 19:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15528
-
core-ci voted on patch set 3 V +1 08/24/21, 19:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15530
-
crell commented on patch set 3 CR +1 08/24/21, 19:49
Ah bon, merci. -
Stefan Bürk commented on patch set 3 08/24/21, 22:09
ShImportant-94280-MoveContentsOfExtPhpIntoLocalScopes.rst:16UnresolvedOr alike .... like anon namespace ? ;) Having a (anon) namespace in an extension ext_localconf.php will hard fail/break a instance. (ext_tables.php not checked). This should state, that having a namespace in extension ext_localconf/ext_tables would break hard the whole instance/installation. Eventually it would better to add a check for the file cache generator. But at least it should marked here, or ? -
Andreas Kienast uploaded patch set 4 08/25/21, 06:24
-
core-ci voted on patch set 4 V +1 08/25/21, 06:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15559
-
Stefan Bürk voted on patch set 4 V +1 CR +1 08/25/21, 06:54
-
Simon Gilli commented on patch set 4 CR -1 08/25/21, 07:22
Important-94280-MoveContentsOfExtPhpIntoLocalScopes.rst:13That's wrong, the namespace is not anonymous but global. -
Simon Gilli commented on patch set 4 08/25/21, 07:25
Important-94280-MoveContentsOfExtPhpIntoLocalScopes.rst:13Reply -
Andreas Kienast commented on patch set 4 08/25/21, 07:26
Important-94280-MoveContentsOfExtPhpIntoLocalScopes.rst:13ReplyPlease see the example from the cache file below, the namespace has no name, hence it's anonymous to my understanding. -
Simon Gilli commented on patch set 4 08/25/21, 07:34
Important-94280-MoveContentsOfExtPhpIntoLocalScopes.rst:13Reply UnresolvedAccording the docs and the patch introducing it it's global. -
Andreas Kienast commented on patch set 5 08/25/21, 07:44
Published edit on patch set 4. -
core-ci voted on patch set 5 V +1 08/25/21, 07:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15560
-
Andreas Kienast commented on patch set 5 CR -2 08/25/21, 08:07
Blocked for now. Simon discovered some weird behavior in PHP with the current approach that will get tackled first. -
Simon Gilli commented on patch set 6 08/25/21, 18:57
Published edit on patch set 5. -
Simon Gilli commented on patch set 6 V +1 CR +1 08/25/21, 18:57
Reply
Moving the imported code to an anonymous namespace is a thing for v12. So I just corrected the wording here for now. Compared to the previous implementation, we can now use the use statement, which is already a big gain and nothing gets worse since the code was also in the globally accessible space before. -
crell voted on patch set 6 CR +1 08/25/21, 19:00
-
core-ci voted on patch set 6 V +1 08/25/21, 19:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15624
-
Andreas Kienast voted on patch set 6 CR 0 08/25/21, 19:10
-
Oli Bartsch voted on patch set 6 V +1 CR +1 08/26/21, 14:35
-
Andreas Kienast voted on patch set 6 V +2 CR +2 08/27/21, 12:54
-
Andreas Kienast merged patch set 7 08/27/21, 12:54