Review main Merged

70744[TASK] Add ReST file for global namespace scoping

Andreas Kienast CR +2 V +2 Normal +61 −0 updated 08/27/21, 12:54

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Simon Gilli +1
    • crell +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Simon Gilli +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 2228

Show 3 earlier messages
  1. Andreas Kienast uploaded patch set 1 08/24/21, 19:08

  2. Andreas Kienast uploaded patch set 2 08/24/21, 19:09

  3. crell commented on patch set 2 08/24/21, 19:19

    Can this also include an example of what one now can/should do in a localconf file? Right now the only example is of what the generated code is. More useful is what I should be writing in my own file(s).
  1. Andreas Kienast commented on patch set 2 08/24/21, 19:22

    Reply

    I thought the last sentence is already properly explaining what we can do here, but sure, I'll update the doc.
  2. core-ci voted on patch set 1 V +1 08/24/21, 19:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15527

  3. Andreas Kienast uploaded patch set 3 08/24/21, 19:27

  4. core-ci voted on patch set 2 V +1 08/24/21, 19:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15528

  5. core-ci voted on patch set 3 V +1 08/24/21, 19:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15530

  6. crell commented on patch set 3 CR +1 08/24/21, 19:49

    Ah bon, merci.
  7. Stefan Bürk commented on patch set 3 08/24/21, 22:09

    Sh

    Important-94280-MoveContentsOfExtPhpIntoLocalScopes.rst:16 Unresolved

    Or alike .... like anon namespace ? ;) Having a (anon) namespace in an extension ext_localconf.php will hard fail/break a instance. (ext_tables.php not checked). This should state, that having a namespace in extension ext_localconf/ext_tables would break hard the whole instance/installation. Eventually it would better to add a check for the file cache generator. But at least it should marked here, or ?
  8. Andreas Kienast uploaded patch set 4 08/25/21, 06:24

  9. core-ci voted on patch set 4 V +1 08/25/21, 06:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15559

  10. Stefan Bürk voted on patch set 4 V +1 CR +1 08/25/21, 06:54

  11. Simon Gilli commented on patch set 4 CR -1 08/25/21, 07:22

    Important-94280-MoveContentsOfExtPhpIntoLocalScopes.rst:13

    That's wrong, the namespace is not anonymous but global.
  12. Simon Gilli commented on patch set 4 08/25/21, 07:25

    Important-94280-MoveContentsOfExtPhpIntoLocalScopes.rst:13 Reply

  13. Andreas Kienast commented on patch set 4 08/25/21, 07:26

    Important-94280-MoveContentsOfExtPhpIntoLocalScopes.rst:13 Reply

    Please see the example from the cache file below, the namespace has no name, hence it's anonymous to my understanding.
  14. Simon Gilli commented on patch set 4 08/25/21, 07:34

    Important-94280-MoveContentsOfExtPhpIntoLocalScopes.rst:13 Reply Unresolved

    According the docs and the patch introducing it it's global.
  15. Andreas Kienast commented on patch set 5 08/25/21, 07:44

    Published edit on patch set 4.
  16. core-ci voted on patch set 5 V +1 08/25/21, 07:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15560

  17. Andreas Kienast commented on patch set 5 CR -2 08/25/21, 08:07

    Blocked for now. Simon discovered some weird behavior in PHP with the current approach that will get tackled first.
  18. Simon Gilli commented on patch set 6 08/25/21, 18:57

    Published edit on patch set 5.
  19. Simon Gilli commented on patch set 6 V +1 CR +1 08/25/21, 18:57

    Reply

    Moving the imported code to an anonymous namespace is a thing for v12. So I just corrected the wording here for now. Compared to the previous implementation, we can now use the use statement, which is already a big gain and nothing gets worse since the code was also in the globally accessible space before.
  20. crell voted on patch set 6 CR +1 08/25/21, 19:00

  21. core-ci voted on patch set 6 V +1 08/25/21, 19:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15624

  22. Andreas Kienast voted on patch set 6 CR 0 08/25/21, 19:10

  23. Oli Bartsch voted on patch set 6 V +1 CR +1 08/26/21, 14:35

  24. Andreas Kienast voted on patch set 6 V +2 CR +2 08/27/21, 12:54

  25. Andreas Kienast merged patch set 7 08/27/21, 12:54