Review main Merged

70746[TASK] Use import instead of FQCN in ext_tables.php files

Wouter Wolters CR +2 V +2 Hard +231 −129 updated 08/26/21, 14:40

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • crell +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 28

Review log 810

  1. Wouter Wolters uploaded patch set 1 08/24/21, 20:40

  2. core-ci voted on patch set 1 V +1 08/24/21, 20:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15535

  3. Wouter Wolters updated the commit message in patch set 2 08/24/21, 20:53

  4. core-ci voted on patch set 2 V +1 08/24/21, 21:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15536

  5. crell voted on patch set 2 CR +1 08/24/21, 21:37

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 08/24/21, 21:53

  7. Oliver Hader commented on patch set 2 CR -1 08/25/21, 08:15

    Explanation later...
  8. Oliver Hader commented on patch set 2 CR 0 08/25/21, 08:25

    Apologies, I had some `Fatal error: Namespace declarations cannot be nested` which I thought could be tracked down to that recent `namespace {` change. However, that was wrong and I could not reproduce it anymore after manually removing cache files...
  9. Oli Bartsch voted on patch set 2 V +2 CR +2 08/26/21, 14:40

  10. Oli Bartsch merged patch set 3 08/26/21, 14:40