Review 10.4 Merged

70747[TASK] Require symfony/filesystem as direct dependency

Oli Bartsch CR +2 V +2 Easy +3 −1 updated 08/25/21, 13:37

Commit message

The package symfony/filesystem is used in the class "CliEntryPoint"
but has no direct dependency defined in main composer.json.
Require the package to not break TYPO3 when packages that rely
on symfony/filesystem get removed.

composer req symfony/filesystem:"^4.4 || ^5.0" --no-update
composer req symfony/filesystem:"^4.4 || ^5.0" -d typo3/sysext/core/ --no-update
composer u --lock

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 1320

  1. Oli Bartsch uploaded patch set 1 08/24/21, 21:31

  2. core-ci voted on patch set 1 V -1 08/24/21, 21:32 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15538

  3. Oli Bartsch uploaded patch set 2 08/24/21, 21:45

  4. Oli Bartsch uploaded patch set 3 08/24/21, 21:49

  5. core-ci voted on patch set 2 V -1 08/24/21, 21:57 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15540

  6. core-ci voted on patch set 3 V +1 08/24/21, 22:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15541

  7. Oli Bartsch uploaded patch set 4 08/24/21, 22:02

  8. core-ci voted on patch set 4 V +1 08/24/21, 22:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15543

  9. Oli Bartsch uploaded patch set 5 08/24/21, 22:16

  10. core-ci voted on patch set 5 V -1 08/24/21, 22:18 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15544

  11. Oli Bartsch uploaded patch set 6 08/24/21, 22:23

  12. Simon Gilli voted on patch set 6 CR +1 08/24/21, 22:24

  13. core-ci voted on patch set 6 V +1 08/24/21, 22:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15545

  14. Simon Gilli voted on patch set 6 V +1 08/24/21, 22:40

  15. Christian Kuhn voted on patch set 6 CR +1 08/25/21, 11:01

  16. Oli Bartsch updated the commit message in patch set 7 08/25/21, 11:35

  17. Wouter Wolters voted on patch set 7 CR +1 08/25/21, 11:39

  18. core-ci voted on patch set 7 V +1 08/25/21, 11:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15585

  19. Oli Bartsch voted on patch set 7 V +2 CR +2 08/25/21, 13:37

  20. Oli Bartsch merged patch set 8 08/25/21, 13:37