70748[TASK] Use import instead of FQCN in ext_localconf.php files
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 29
- typo3/sysext/adminpanel/ext_localconf.php+34 −16
- typo3/sysext/backend/ext_localconf.php+27 −13
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/ext_localconf.php+8 −4
- typo3/sysext/core/ext_localconf.php+53 −29
- typo3/sysext/dashboard/ext_localconf.php+5 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_localconf.php+8 −4
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/class_overriding/b/ext_localconf.php+8 −3
- typo3/sysext/extbase/ext_localconf.php+30 −14
- typo3/sysext/extensionmanager/ext_localconf.php+11 −5
- typo3/sysext/felogin/ext_localconf.php+19 −12
- typo3/sysext/filelist/ext_localconf.php+3 −1
- typo3/sysext/form/ext_localconf.php5+30 −19
- typo3/sysext/frontend/ext_localconf.php+46 −25
- typo3/sysext/impexp/ext_localconf.php+3 −1
- typo3/sysext/indexed_search/ext_localconf.php+46 −36
- typo3/sysext/install/ext_localconf.php+27 −13
- typo3/sysext/linkvalidator/ext_localconf.php+13 −6
- typo3/sysext/opendocs/ext_localconf.php+4 −2
- typo3/sysext/recordlist/ext_localconf.php+10 −5
- typo3/sysext/recycler/ext_localconf.php+5 −2
Show 9 more files
- typo3/sysext/redirects/ext_localconf.php+17 −8
- typo3/sysext/reports/ext_localconf.php+21 −10
- typo3/sysext/rte_ckeditor/ext_localconf.php+5 −2
- typo3/sysext/scheduler/ext_localconf.php+53 −30
- typo3/sysext/seo/ext_localconf.php+15 −7
- typo3/sysext/sys_note/ext_localconf.php+8 −4
- typo3/sysext/t3editor/ext_localconf.php+7 −3
- typo3/sysext/tstemplate/ext_localconf.php+3 −1
- typo3/sysext/workspaces/ext_localconf.php+12 −7
Review log 2024
-
Wouter Wolters uploaded patch set 1 08/24/21, 21:57
-
core-ci voted on patch set 1 V +1 08/24/21, 22:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15542
-
Christian Kuhn commented on patch set 1 08/25/21, 07:36
please give relations some love :) a "Related: #" to the patch that allowed this would be great. -
Oliver Hader commented on patch set 1 CR -1 08/25/21, 08:15
Explanation later... -
Oliver Hader commented on patch set 1 CR 0 08/25/21, 08:25
Apologies, I had some `Fatal error: Namespace declarations cannot be nested` which I thought could be tracked down to that recent `namespace {` change. However, that was wrong and I could not reproduce it anymore after manually removing cache files... -
Wouter Wolters updated the commit message in patch set 2 08/30/21, 09:52
-
core-ci voted on patch set 2 V +1 08/30/21, 10:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15849
-
Andreas Kienast voted on patch set 2 V +1 CR +1 08/30/21, 20:46
-
Jonas Eberle voted on patch set 2 V +1 08/31/21, 07:06
-
Wouter Wolters uploaded patch set 3 09/07/21, 19:29
-
core-ci voted on patch set 3 V +1 09/07/21, 19:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16389
-
Andreas Kienast voted on patch set 3 V +1 CR +1 09/08/21, 06:52
-
Jonas Eberle commented on patch set 3 09/08/21, 06:57
ext_localconf.php:24That removal seems unrelated? -
Oliver Hader commented on patch set 3 09/08/21, 07:04
ext_localconf.php:24ReplySeems to be a drive-by clean-up since `FileListEditIconsHook` does not exist anymore. -
Oliver Hader commented on patch set 3 CR +1 09/08/21, 07:07
ext_localconf.php:24ReplyAh... when comparing 2..3 Gerrit (still) shows this as change... however it's actually not part of the changeset, but stems from another merge that happened in between. -
Wouter Wolters commented on patch set 3 09/08/21, 07:10
ext_localconf.php:24ReplyYes that is my bad. I picked the file from master and re did the cleanup instead of resolving te conflict. -
Jonas Eberle commented on patch set 3 V +1 09/08/21, 07:18
ext_localconf.php:24ReplyYes, sorry, I got confused. I was looking at 2..3 -
Oliver Hader commented on patch set 3 09/08/21, 07:19
When looking into a cached file (e.g. typo3temp/var/cache/code/core/ext_localconf_9dabce73ecd5460ead360252d6db48b70b4ce191.php) PhpStorm adds warning e.g. on duplicate `use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;` statements. However, I did not find any problem when calling or linting the file directly with PHP 7.4 or PHP 8.0 - this just seems to be a PhpStorm thingy. Anyway, can you double-check or double-research whether the might be implications? -
Anja Leichsenring uploaded patch set 4 09/11/21, 12:42
-
Christian Kuhn voted on patch set 4 V +1 CR +1 09/11/21, 12:49
-
core-ci voted on patch set 4 V +1 09/11/21, 13:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16553
-
Anja Leichsenring voted on patch set 4 V +2 CR +2 09/11/21, 13:06
-
Anja Leichsenring merged patch set 5 09/11/21, 13:06
-
Anja Leichsenring commented on patch set 5 09/11/21, 13:06
Reply
Done