Review main Merged

70748[TASK] Use import instead of FQCN in ext_localconf.php files

Wouter Wolters CR +2 V +2 Hard +531 −284 updated 09/11/21, 13:06

Commit message

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 29

Show 9 more files

Review log 2024

  1. Wouter Wolters uploaded patch set 1 08/24/21, 21:57

  2. core-ci voted on patch set 1 V +1 08/24/21, 22:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15542

  3. Christian Kuhn commented on patch set 1 08/25/21, 07:36

    please give relations some love :) a "Related: #" to the patch that allowed this would be great.
  4. Oliver Hader commented on patch set 1 CR -1 08/25/21, 08:15

    Explanation later...
  5. Oliver Hader commented on patch set 1 CR 0 08/25/21, 08:25

    Apologies, I had some `Fatal error: Namespace declarations cannot be nested` which I thought could be tracked down to that recent `namespace {` change. However, that was wrong and I could not reproduce it anymore after manually removing cache files...
  6. Wouter Wolters updated the commit message in patch set 2 08/30/21, 09:52

  7. core-ci voted on patch set 2 V +1 08/30/21, 10:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15849

  8. Andreas Kienast voted on patch set 2 V +1 CR +1 08/30/21, 20:46

  9. Jonas Eberle voted on patch set 2 V +1 08/31/21, 07:06

  10. Wouter Wolters uploaded patch set 3 09/07/21, 19:29

  11. core-ci voted on patch set 3 V +1 09/07/21, 19:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16389

  12. Andreas Kienast voted on patch set 3 V +1 CR +1 09/08/21, 06:52

  13. Jonas Eberle commented on patch set 3 09/08/21, 06:57

    ext_localconf.php:24

    That removal seems unrelated?
  14. Oliver Hader commented on patch set 3 09/08/21, 07:04

    ext_localconf.php:24 Reply

    Seems to be a drive-by clean-up since `FileListEditIconsHook` does not exist anymore.
  15. Oliver Hader commented on patch set 3 CR +1 09/08/21, 07:07

    ext_localconf.php:24 Reply

    Ah... when comparing 2..3 Gerrit (still) shows this as change... however it's actually not part of the changeset, but stems from another merge that happened in between.
  16. Wouter Wolters commented on patch set 3 09/08/21, 07:10

    ext_localconf.php:24 Reply

    Yes that is my bad. I picked the file from master and re did the cleanup instead of resolving te conflict.
  17. Jonas Eberle commented on patch set 3 V +1 09/08/21, 07:18

    ext_localconf.php:24 Reply

    Yes, sorry, I got confused. I was looking at 2..3
  18. Oliver Hader commented on patch set 3 09/08/21, 07:19

    When looking into a cached file (e.g. typo3temp/var/cache/code/core/ext_localconf_9dabce73ecd5460ead360252d6db48b70b4ce191.php) PhpStorm adds warning e.g. on duplicate `use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;` statements. However, I did not find any problem when calling or linting the file directly with PHP 7.4 or PHP 8.0 - this just seems to be a PhpStorm thingy. Anyway, can you double-check or double-research whether the might be implications?
  19. Anja Leichsenring uploaded patch set 4 09/11/21, 12:42

  20. Christian Kuhn voted on patch set 4 V +1 CR +1 09/11/21, 12:49

  21. core-ci voted on patch set 4 V +1 09/11/21, 13:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16553

  22. Anja Leichsenring voted on patch set 4 V +2 CR +2 09/11/21, 13:06

  23. Anja Leichsenring merged patch set 5 09/11/21, 13:06

  24. Anja Leichsenring commented on patch set 5 09/11/21, 13:06

    Reply

    Done