Review main Merged

70750[TASK] Move column selector to EXT:backend

Oli Bartsch CR +2 V +2 Hard +209 −250 updated 08/26/21, 12:48

Commit message

The column selector component is moved to
EXT:backend. This allows to use it in further
modules without adding cross dependencies to
EXT:recordlist.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 1321

  1. Oli Bartsch uploaded patch set 1 08/25/21, 00:51

  2. core-ci voted on patch set 1 V -1 08/25/21, 01:04 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15551

  3. Oli Bartsch uploaded patch set 2 08/25/21, 09:28

  4. core-ci voted on patch set 2 V +1 08/25/21, 09:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15572

  5. Oli Bartsch uploaded patch set 3 08/25/21, 11:13

  6. Oli Bartsch uploaded patch set 4 08/25/21, 11:24

  7. core-ci voted on patch set 3 V -1 08/25/21, 11:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15582

  8. core-ci voted on patch set 4 V -1 08/25/21, 11:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15583

  9. Oli Bartsch uploaded patch set 5 08/25/21, 12:44

  10. core-ci voted on patch set 5 V +1 08/25/21, 13:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15595

  11. Oli Bartsch uploaded patch set 6 08/25/21, 23:02

  12. core-ci voted on patch set 6 V +1 08/25/21, 23:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15638

  13. Christian Kuhn commented on patch set 6 08/26/21, 04:28

    Straight move of code. In general fine with me, and agreed, this code needs to be bound to ext:backend and not ext:recordlist. Just slightly mumbling about the BackendUtility method, see the comment. Maybe worth some additional minutes of love to have a second look at this?

    BackendUtility.php:3640

    In general i'm not a huge fan of adding additional stuff to BackendUtility. But if have no good idea for a location that provides better modeling at hand in this case, either. And this method is "mostly harmless", so ... fine with me. Could we maybe argue about the method name and comment a bit, though? makeFieldList() does not say much and "Makes the list of fields to select for a table" is not *that* great, either. Sorry naming things ... and while at it: We could turn "bool $dontCheckUser = false" around (double negative is hard to read), *maybe* rethink this $addDateFields thing. Do we really need that? Why are the date fields so special and why this admin dependency? This somehow looks like a leftover ... I may be wrong, so ignore this if needed. My general stance is: If we move such things around from some controller class to a more generic position, we should embrace the opportunity and re-think naming stuff and signature. What do you think? Don't wanna block here, either, of course.
  14. Oli Bartsch uploaded patch set 7 08/26/21, 10:47

  15. Oli Bartsch commented on patch set 7 08/26/21, 10:48

    BackendUtility.php:3640 Reply

    Done
  16. core-ci voted on patch set 7 V -1 08/26/21, 11:07 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15661

  17. core-ci voted on patch set 7 V +1 08/26/21, 11:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15661

  18. Christian Kuhn voted on patch set 7 V +1 CR +1 08/26/21, 12:01

  19. Jochen Roth voted on patch set 7 V +1 CR +1 08/26/21, 12:42

  20. Christian Kuhn voted on patch set 7 V +2 CR +2 08/26/21, 12:48

  21. Christian Kuhn merged patch set 8 08/26/21, 12:48