Review main Merged

70752[TASK] Improve Package Manager API

Benni Mack CR +2 V +2 Normal +33 −78 updated 08/25/21, 14:10

Commit message

This change is a precursor to
https://review.typo3.org/c/Packages/TYPO3.CMS/+/69174

This change effectively:
* Centralizes checks to PackageStates.php in Bootstrap
* Centralizes some specific Install-Tool functionality in PackageManager
* Adds a cache identifier for ext_localconf/TCA/ext_tables.php from the packagemanager

The last adaption allows to have custom cache identifier
when the active packages have been updated.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1722

  1. Benni Mack uploaded patch set 1 08/25/21, 09:01

  2. core-ci voted on patch set 1 V -1 08/25/21, 09:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15571

  3. Benni Mack uploaded patch set 2 08/25/21, 11:39

  4. core-ci voted on patch set 2 V +1 08/25/21, 12:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15586

  5. Helmut Hummel voted on patch set 2 V +2 CR +2 08/25/21, 12:38

  6. Helmut Hummel commented on patch set 2 V 0 CR 0 08/25/21, 12:43

    InstallerController.php:247

    isn't that also the same as done in createPackageStatesFileIfMissing?
  7. Benni Mack commented on patch set 2 08/25/21, 12:45

    InstallerController.php:247 Reply

    good point! will update!
  8. Christian Kuhn commented on patch set 2 08/25/21, 12:50

    InstallerController.php:247 Reply Unresolved

    Difference is isPartOfFactoryDefault() vs. isPartOfMinimalUsableSystem(): When *installing*, factory packages are activated, when running instance misses PackageStates.php, only *minimalUsableSystem" packages are activated. I'd keep the code here as is.
  9. Benni Mack uploaded patch set 3 08/25/21, 12:51

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 08/25/21, 13:00

  11. Helmut Hummel commented on patch set 3 08/25/21, 13:02

    PackageManager.php:169

    nice, we can now make this protected or maybe even remove it, as it's now only used in one internal mehod
  12. Christian Kuhn commented on patch set 3 CR -1 08/25/21, 13:06

    will update.

    PackageManager.php:169 Reply Unresolved

    yep.
  13. Helmut Hummel uploaded patch set 4 08/25/21, 13:06

  14. core-ci voted on patch set 3 V +1 08/25/21, 13:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15596

  15. Benni Mack voted on patch set 4 CR +1 08/25/21, 13:20

  16. Helmut Hummel voted on patch set 4 V +1 CR +1 08/25/21, 13:21

  17. Christian Kuhn voted on patch set 4 V +1 CR +1 08/25/21, 13:36

  18. core-ci voted on patch set 4 V -1 08/25/21, 13:46 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15597

  19. core-ci voted on patch set 4 V +1 08/25/21, 13:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15597

  20. Benni Mack voted on patch set 4 V +2 CR +2 08/25/21, 14:02

  21. Benni Mack merged patch set 5 08/25/21, 14:02

  22. Helmut Hummel commented on patch set 5 08/25/21, 14:10

    nice, thanks!