70752[TASK] Improve Package Manager API
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Helmut Hummel +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Helmut Hummel +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/backend/Classes/Http/Application.php+2 −13
- typo3/sysext/core/Classes/Console/CommandApplication.php+1 −12
- typo3/sysext/core/Classes/Core/Bootstrap.php+1 −1
- typo3/sysext/core/Classes/Package/FailsafePackageManager.php+21 −0
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+3 −3
- typo3/sysext/frontend/Classes/Http/Application.php+2 −13
- typo3/sysext/install/Classes/Controller/InstallerController.php3+1 −13
- typo3/sysext/install/Classes/Middleware/Maintenance.php+2 −23
Review log 1722
-
Benni Mack uploaded patch set 1 08/25/21, 09:01
-
core-ci voted on patch set 1 V -1 08/25/21, 09:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15571
-
Benni Mack uploaded patch set 2 08/25/21, 11:39
-
core-ci voted on patch set 2 V +1 08/25/21, 12:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15586
-
Helmut Hummel voted on patch set 2 V +2 CR +2 08/25/21, 12:38
-
Helmut Hummel commented on patch set 2 V 0 CR 0 08/25/21, 12:43
-
Benni Mack commented on patch set 2 08/25/21, 12:45
InstallerController.php:247Replygood point! will update! -
Christian Kuhn commented on patch set 2 08/25/21, 12:50
InstallerController.php:247Reply UnresolvedDifference is isPartOfFactoryDefault() vs. isPartOfMinimalUsableSystem(): When *installing*, factory packages are activated, when running instance misses PackageStates.php, only *minimalUsableSystem" packages are activated. I'd keep the code here as is. -
Benni Mack uploaded patch set 3 08/25/21, 12:51
-
Christian Kuhn voted on patch set 3 V +1 CR +1 08/25/21, 13:00
-
Helmut Hummel commented on patch set 3 08/25/21, 13:02
PackageManager.php:169nice, we can now make this protected or maybe even remove it, as it's now only used in one internal mehod -
Christian Kuhn commented on patch set 3 CR -1 08/25/21, 13:06
will update.PackageManager.php:169Reply Unresolvedyep. -
Helmut Hummel uploaded patch set 4 08/25/21, 13:06
-
core-ci voted on patch set 3 V +1 08/25/21, 13:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15596
-
Benni Mack voted on patch set 4 CR +1 08/25/21, 13:20
-
Helmut Hummel voted on patch set 4 V +1 CR +1 08/25/21, 13:21
-
Christian Kuhn voted on patch set 4 V +1 CR +1 08/25/21, 13:36
-
core-ci voted on patch set 4 V -1 08/25/21, 13:46 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15597
-
core-ci voted on patch set 4 V +1 08/25/21, 13:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15597
-
Benni Mack voted on patch set 4 V +2 CR +2 08/25/21, 14:02
-
Benni Mack merged patch set 5 08/25/21, 14:02
-
Helmut Hummel commented on patch set 5 08/25/21, 14:10
nice, thanks!
InstallerController.php:247