Review 9.5 Merged

70755[BUGFIX] Correctly resolve nested arguments in SimpleEnhancer

Oliver Hader CR +2 V +2 Normal +39 −20 updated 08/25/21, 10:13

Commit message

Having `additionalParams = &simple[id]=okay&simple[other]=other`
with the following route enhancer configuration lead to some flaws:

    routeEnhancers:
      TestSimple:
        type: Simple
        routePath: '/simple/{simple_id}'
        _arguments:
          simple_id: 'simple/id'

* generated URI contained `simple__other`, not resolving nesting
  (`/simple/okay?simple__other=other&cHash=...`)
* `PageArguments::$staticArguments` contained parameter `simple_id`
  (unresolved to actual query parameter, incorrectly marked static)
* other `PageArguments` properties contained `simple__other`
  (unresolved to actual query parameter, ignored nesting)

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Oliver Hader uploaded patch set 1 08/25/21, 09:57

  2. core-ci voted on patch set 1 V +1 08/25/21, 10:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15575

  3. Oliver Hader voted on patch set 1 V +2 CR +2 08/25/21, 10:12

  4. Oliver Hader merged patch set 2 08/25/21, 10:13