70757[TASK] Public GeneralUtility::xml2arrayProcess()
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- crell +1
- Daniel Siepmann +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Daniel Siepmann +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1623
-
Daniel Siepmann uploaded patch set 1 08/25/21, 13:12
-
Daniel Siepmann uploaded patch set 2 08/25/21, 13:22
-
Christian Kuhn commented on patch set 2 08/25/21, 13:33
[TASK], imho.GeneralUtility.php:1480alternative: make xml2arrayProcess() public. I'd prefer that, actually, since xml2array() is exactly only a just cache layer around xml2arrayProcess(). -
core-ci voted on patch set 1 V +1 08/25/21, 13:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15598
-
Daniel Siepmann updated the commit message in patch set 3 08/25/21, 13:36
-
Daniel Siepmann uploaded patch set 4 08/25/21, 13:36
-
Daniel Siepmann commented on patch set 4 08/25/21, 13:37
Reply
DoneGeneralUtility.php:1480ReplyDone -
core-ci voted on patch set 3 V +1 08/25/21, 13:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15601
-
core-ci voted on patch set 2 V +1 08/25/21, 13:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15600
-
core-ci voted on patch set 4 V +1 08/25/21, 13:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15602
-
Christian Kuhn commented on patch set 4 CR -1 08/25/21, 14:15
will try to simplify the according unit tests a bit. -
Christian Kuhn uploaded patch set 5 08/25/21, 14:36
-
Christian Kuhn uploaded patch set 6 08/25/21, 14:43
-
Christian Kuhn updated the commit message in patch set 7 08/25/21, 14:46
-
Christian Kuhn voted on patch set 7 V +1 CR +1 08/25/21, 14:46
-
core-ci voted on patch set 5 V +1 08/25/21, 14:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15604
-
core-ci voted on patch set 6 V -1 08/25/21, 15:06 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15605
-
core-ci voted on patch set 7 V +1 08/25/21, 15:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15606
-
Jochen Roth voted on patch set 7 V +1 CR +1 08/25/21, 15:36
-
Daniel Siepmann voted on patch set 7 V +1 CR +1 08/25/21, 15:58
-
crell commented on patch set 7 CR +1 08/25/21, 16:30
Splitting the logic and caching to separate methods is generally good, for exactly this testing reason. Endorse. -
Christian Kuhn voted on patch set 7 V +2 CR +2 08/25/21, 17:47
-
Christian Kuhn merged patch set 8 08/25/21, 17:47