Review main Merged

70757[TASK] Public GeneralUtility::xml2arrayProcess()

Daniel Siepmann CR +2 V +2 Normal +37 −56 updated 08/25/21, 17:47

Commit message

It can be beneficial to suppress caching using
xml2arrayProcess() directly instead of the cache
enabled wrapper xml2array() in some situations.

The patch makes the worker method public, adapts
tests to mock less and moves a data changing detail
from xml2array() to xml2arrayProcess().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • crell +1
    • Daniel Siepmann +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Daniel Siepmann +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1623

  1. Daniel Siepmann uploaded patch set 1 08/25/21, 13:12

  2. Daniel Siepmann uploaded patch set 2 08/25/21, 13:22

  3. Christian Kuhn commented on patch set 2 08/25/21, 13:33

    [TASK], imho.

    GeneralUtility.php:1480

    alternative: make xml2arrayProcess() public. I'd prefer that, actually, since xml2array() is exactly only a just cache layer around xml2arrayProcess().
  4. core-ci voted on patch set 1 V +1 08/25/21, 13:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15598

  5. Daniel Siepmann updated the commit message in patch set 3 08/25/21, 13:36

  6. Daniel Siepmann uploaded patch set 4 08/25/21, 13:36

  7. Daniel Siepmann commented on patch set 4 08/25/21, 13:37

    Reply

    Done

    GeneralUtility.php:1480 Reply

    Done
  8. core-ci voted on patch set 3 V +1 08/25/21, 13:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15601

  9. core-ci voted on patch set 2 V +1 08/25/21, 13:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15600

  10. core-ci voted on patch set 4 V +1 08/25/21, 13:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15602

  11. Christian Kuhn commented on patch set 4 CR -1 08/25/21, 14:15

    will try to simplify the according unit tests a bit.
  12. Christian Kuhn uploaded patch set 5 08/25/21, 14:36

  13. Christian Kuhn uploaded patch set 6 08/25/21, 14:43

  14. Christian Kuhn updated the commit message in patch set 7 08/25/21, 14:46

  15. Christian Kuhn voted on patch set 7 V +1 CR +1 08/25/21, 14:46

  16. core-ci voted on patch set 5 V +1 08/25/21, 14:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15604

  17. core-ci voted on patch set 6 V -1 08/25/21, 15:06 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15605

  18. core-ci voted on patch set 7 V +1 08/25/21, 15:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15606

  19. Jochen Roth voted on patch set 7 V +1 CR +1 08/25/21, 15:36

  20. Daniel Siepmann voted on patch set 7 V +1 CR +1 08/25/21, 15:58

  21. crell commented on patch set 7 CR +1 08/25/21, 16:30

    Splitting the logic and caching to separate methods is generally good, for exactly this testing reason. Endorse.
  22. Christian Kuhn voted on patch set 7 V +2 CR +2 08/25/21, 17:47

  23. Christian Kuhn merged patch set 8 08/25/21, 17:47