Review main Merged

70759[TASK] Move metadata translation to action button in filelist

Oli Bartsch CR +2 V +2 Normal +98 −108 updated 08/26/21, 09:42

Commit message

Creating and editing file metadata translations is usually
done in the filelist module. Therefore a custom toggle
button in the "Localization" column had to be used.

In the expanded state, various flag icons with an hard
to guess overlay icon were displayed. Those could be
used to either create or edit the file metadata records.

This however had some drawbacks:

- The toggle button was not accessible by keyboard
- As toggle icon, the "pages languages overlay" icon
  was used, making it hard to understand for editors
- As soon as one of those toggle buttons was clicked,
  all other toggle buttons jumped to the left

To improve this, the toggle button is moved into the
controls group and does now uses the "actions-translate"
icon. It furthermore does now open a dropdown with
proper link labels - as already known from the secondary
menu. This therefore also increases consistency.

Besides the visual changes, this patch also cleans
up the underlying code and removes the custom
JavaScript component, which was used for the
toggle button.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1014

  1. Oli Bartsch uploaded patch set 1 08/25/21, 22:39

  2. core-ci voted on patch set 1 V -1 08/25/21, 23:01 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15636

  3. Oli Bartsch uploaded patch set 2 08/25/21, 23:30

  4. core-ci voted on patch set 2 V -1 08/25/21, 23:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15640

  5. Oli Bartsch uploaded patch set 3 08/26/21, 00:00

  6. core-ci voted on patch set 3 V +1 08/26/21, 00:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15642

  7. Christian Kuhn commented on patch set 3 V -1 08/26/21, 04:58

    Ah. Feels much better to use now! Minor nitpick codewise, but a real issue, too: console when clicking the button: "Bootstrap doesn't allow more than one instance per element. Bound instance: bs.tooltip." ... guess that's also the reason the menu does not close again when i click elsewhere after it has been opened.

    FileList.php:1262

    Does not matter too much, but i prefer constant LF for html output: There is no point in creating different html depending on OS platform. In general there is little reason to use PHP_EOL at all, maybe CLI ...
  8. Oli Bartsch uploaded patch set 4 08/26/21, 09:17

  9. Oli Bartsch commented on patch set 4 08/26/21, 09:17

    FileList.php:1262 Reply

    Done
  10. core-ci voted on patch set 4 V +1 08/26/21, 09:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15660

  11. Christian Kuhn voted on patch set 4 V +1 CR +1 08/26/21, 09:39

  12. Jochen Roth voted on patch set 4 V +1 CR +1 08/26/21, 09:39

  13. Oli Bartsch voted on patch set 4 V +2 CR +2 08/26/21, 09:42

  14. Oli Bartsch merged patch set 5 08/26/21, 09:42