70759[TASK] Move metadata translation to action button in filelist
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/filelist/Resources/Public/TypeScript/FileListLocalisation.tsdeleted+0 −32
- typo3/sysext/core/Tests/Acceptance/Application/FileList/AbstractFileCest.php+1 −1
- typo3/sysext/filelist/Classes/Controller/FileListController.php+0 −1
- typo3/sysext/filelist/Classes/FileList.php2+97 −61
- typo3/sysext/filelist/Resources/Public/JavaScript/FileListLocalisation.jsdeleted+0 −13
Review log 1014
-
Oli Bartsch uploaded patch set 1 08/25/21, 22:39
-
core-ci voted on patch set 1 V -1 08/25/21, 23:01 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15636
-
Oli Bartsch uploaded patch set 2 08/25/21, 23:30
-
core-ci voted on patch set 2 V -1 08/25/21, 23:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15640
-
Oli Bartsch uploaded patch set 3 08/26/21, 00:00
-
core-ci voted on patch set 3 V +1 08/26/21, 00:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15642
-
Christian Kuhn commented on patch set 3 V -1 08/26/21, 04:58
Ah. Feels much better to use now! Minor nitpick codewise, but a real issue, too: console when clicking the button: "Bootstrap doesn't allow more than one instance per element. Bound instance: bs.tooltip." ... guess that's also the reason the menu does not close again when i click elsewhere after it has been opened.FileList.php:1262Does not matter too much, but i prefer constant LF for html output: There is no point in creating different html depending on OS platform. In general there is little reason to use PHP_EOL at all, maybe CLI ... -
Oli Bartsch uploaded patch set 4 08/26/21, 09:17
-
Oli Bartsch commented on patch set 4 08/26/21, 09:17
FileList.php:1262ReplyDone -
core-ci voted on patch set 4 V +1 08/26/21, 09:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15660
-
Christian Kuhn voted on patch set 4 V +1 CR +1 08/26/21, 09:39
-
Jochen Roth voted on patch set 4 V +1 CR +1 08/26/21, 09:39
-
Oli Bartsch voted on patch set 4 V +2 CR +2 08/26/21, 09:42
-
Oli Bartsch merged patch set 5 08/26/21, 09:42