70760[BUGFIX] Add missing autocomplete for TOTP field
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Mathias Brodala +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1011
-
Simon Schaufelberger uploaded patch set 1 08/25/21, 22:49
-
Oli Bartsch commented on patch set 1 08/25/21, 23:08
Are you sure that this is correct? Isn't this value used to tell password managers to fill an *existing* OTP? Unfortunately MDN is not really clear here: > "one-time-code" > A one-time code used for verifying user identity. -
core-ci voted on patch set 1 V +1 08/25/21, 23:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15637
-
Simon Schaufelberger commented on patch set 1 09/05/21, 00:57
Reply
It should be the first generated number by the MFA app. Should we use autocomplete here or disable it completely? -
Oliver Klee voted on patch set 1 CR +1 09/05/21, 07:51
-
Mathias Brodala voted on patch set 1 CR +1 09/24/21, 13:46
-
Benni Mack voted on patch set 1 CR +1 09/27/21, 11:13
-
Oli Bartsch commented on patch set 1 V +1 CR +1 09/28/21, 14:54
Ok, this seems to work. Actually my password manager already filled this correctly because of the input fields' name being "totp". -
Benni Mack voted on patch set 1 V +1 09/28/21, 15:05
-
Oli Bartsch voted on patch set 1 V +2 CR +2 09/28/21, 15:18
-
Oli Bartsch merged patch set 2 09/28/21, 15:18