Review main Merged

70761[BUGFIX] Fix initialization of TOTP info modal

Oli Bartsch CR +2 V +2 Easy +3 −2 updated 08/26/21, 09:03

Commit message

The TOTP info modal displays the OTP auth url
along with a description. This content however
is added to the modal body by a callback. To
prevent the "modal content empty" warning
from being shown, the modal is now initialized
with an empty string as content.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 08/25/21, 23:55

  2. core-ci voted on patch set 1 V +1 08/26/21, 00:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15641

  3. Christian Kuhn commented on patch set 1 V +1 CR +1 08/26/21, 04:04

    to test: top bar -> user -> user settings -> account security -> "setup mfa authentication" button -> "Time-based one-time password" -> the "I" button on "Copy the shared secret" input field -> modal opens -> text "No content provided, please check your <code>Modal</code> configuration." shown in modal content (which is the bug) apply patch -> this part of the modal content is gone.
  4. Jochen Roth voted on patch set 1 V +1 CR +1 08/26/21, 09:02

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 08/26/21, 09:03

  6. Oli Bartsch merged patch set 2 08/26/21, 09:03