70762[TASK] Obsolete NotFoundView and deprecate canRender()
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Jochen Roth +1
- Wouter Wolters +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Jochen Roth +1
- Wouter Wolters +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/backend/Classes/View/BackendTemplateView.php+4 −3
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-95003-ExtbaseViewInterfaceCanRender.rstnew+41 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+0 −9
- typo3/sysext/extbase/Classes/Mvc/View/AbstractView.php+3 −2
- typo3/sysext/extbase/Classes/Mvc/View/EmptyView.php+3 −2
- typo3/sysext/extbase/Classes/Mvc/View/JsonView.php+3 −2
- typo3/sysext/extbase/Classes/Mvc/View/NotFoundView.phpdeleted+0 −155
- typo3/sysext/extbase/Classes/Mvc/View/ViewInterface.php+0 −8
- typo3/sysext/extbase/Resources/Private/MVC/NotFoundView_Template.htmldeleted+0 −2
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ActionControllerTest.php+3 −3
- typo3/sysext/fluid/Classes/View/AbstractTemplateView.php+2 −0
- typo3/sysext/fluid/Classes/View/TemplateView.php+0 −22
Review log 913
-
Christian Kuhn uploaded patch set 1 08/26/21, 07:56
-
core-ci voted on patch set 1 V -1 08/26/21, 07:59 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15649
-
Christian Kuhn uploaded patch set 2 08/26/21, 08:27
-
core-ci voted on patch set 2 V -1 08/26/21, 08:50 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15654
-
core-ci voted on patch set 2 V +1 08/26/21, 09:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15654
-
Christian Kuhn uploaded patch set 3 08/26/21, 11:29
-
core-ci voted on patch set 3 V +1 08/26/21, 11:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15665
-
Jochen Roth voted on patch set 3 V +1 CR +1 08/26/21, 12:33
-
Wouter Wolters voted on patch set 3 V +1 CR +1 08/26/21, 13:02
-
Oli Bartsch commented on patch set 3 08/26/21, 15:42
With this patch applied and having `config.contentObjectExceptionHandler = 1` set (which is the default on production context), following message is rendered in frontend: > Oops, an error occurred! Code: {code} -
Oli Bartsch commented on patch set 3 V +1 CR +1 08/26/21, 16:26
Reply
-
Christian Kuhn voted on patch set 3 V +2 CR +2 08/26/21, 16:28
-
Christian Kuhn merged patch set 4 08/26/21, 16:28