Review main Merged

70769[TASK] Deprecate extbase EmptyView

Christian Kuhn CR +2 V +2 Normal +53 −0 updated 08/26/21, 15:00

Commit message

Extbase EmptyView is unused since its introduction in
4.5. Calling render() returns a html comment. It has
been substituted by NotFoundView within 4.5 development
already. NotFoundView is removed with a different
patch, too.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 67

  1. Christian Kuhn uploaded patch set 1 08/26/21, 12:38

  2. core-ci voted on patch set 1 V +1 08/26/21, 12:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15671

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 08/26/21, 13:01

  4. Jochen Roth voted on patch set 1 V +1 CR +1 08/26/21, 13:10

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 08/26/21, 14:21

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 08/26/21, 15:00

  7. Christian Kuhn merged patch set 2 08/26/21, 15:00