70792[BUGFIX] Avoid access to $_SERVER['REQUEST_TIME']
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benjamin Franzke +1
- Jochen Roth +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- core-ci +1 CI
Issues 2
Files 7
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-95009-PassingTypoScriptConfigurationAsConstructorArgumentToExceptionHandler.rstnew+43 −0
- typo3/sysext/frontend/Classes/ContentObject/Exception/ExceptionHandlerInterface.php+7 −0
- typo3/sysext/frontend/Classes/ContentObject/Exception/ProductionExceptionHandler.php+31 −29
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+10 −1
- typo3/sysext/frontend/Configuration/Services.yaml+4 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/Exception/ProductionExceptionHandlerTest.php+26 −16
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+12 −3
Review log 1015
-
Oli Bartsch uploaded patch set 1 08/26/21, 18:06
-
Oli Bartsch updated the commit message in patch set 2 08/26/21, 18:16
-
core-ci voted on patch set 1 V -1 08/26/21, 18:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15686
-
Christian Kuhn commented on patch set 2 CR -1 08/26/21, 18:30
i'll think about the DI options here and will probably update this soon. -
core-ci voted on patch set 2 V -1 08/26/21, 18:32 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15687
-
Oli Bartsch uploaded patch set 3 09/03/21, 09:57
-
Oli Bartsch uploaded patch set 4 09/03/21, 10:01
-
core-ci voted on patch set 3 V -1 09/03/21, 10:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16164
-
core-ci voted on patch set 4 V -1 09/03/21, 10:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16165
-
Oli Bartsch uploaded patch set 5 09/03/21, 11:38
-
core-ci voted on patch set 5 V +1 09/03/21, 11:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16170
-
Jochen Roth voted on patch set 5 V +1 CR +1 09/03/21, 13:02
-
Benjamin Franzke voted on patch set 5 CR +1 09/03/21, 13:49
-
Christian Kuhn voted on patch set 5 V +2 CR +2 09/06/21, 11:29
-
Christian Kuhn merged patch set 6 09/06/21, 11:29