Review main Merged

70792[BUGFIX] Avoid access to $_SERVER['REQUEST_TIME']

Oli Bartsch CR +2 V +2 Normal +133 −49 updated 09/06/21, 11:29

Commit message

The ProductionExceptionHandler now uses the
Context API for generating the access time
string, which among others, is used in the
error code. Therefore, the class is also
refactored to use DI. This required to
remove the previously passed $configuration
argument from the constructor. It will now
be set via a new `setConfiguration()` method.
Passing the $configuration as constructor
argument is marked as deprecated, affecting
installations, using custom exception handler
classes.

Additionally, another regression, introduced
in #94315, is fixed. A custom error message,
configured in TypoScript, using the `%s`
placeholder, was no longer be substituted with
the actual error, making any mapping between
frontend output and log entry impossible. This
is fixed by replacing the `%s` with the new
`{code}` placeholder.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 1015

  1. Oli Bartsch uploaded patch set 1 08/26/21, 18:06

  2. Oli Bartsch updated the commit message in patch set 2 08/26/21, 18:16

  3. core-ci voted on patch set 1 V -1 08/26/21, 18:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15686

  4. Christian Kuhn commented on patch set 2 CR -1 08/26/21, 18:30

    i'll think about the DI options here and will probably update this soon.
  5. core-ci voted on patch set 2 V -1 08/26/21, 18:32 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15687

  6. Oli Bartsch uploaded patch set 3 09/03/21, 09:57

  7. Oli Bartsch uploaded patch set 4 09/03/21, 10:01

  8. core-ci voted on patch set 3 V -1 09/03/21, 10:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16164

  9. core-ci voted on patch set 4 V -1 09/03/21, 10:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16165

  10. Oli Bartsch uploaded patch set 5 09/03/21, 11:38

  11. core-ci voted on patch set 5 V +1 09/03/21, 11:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16170

  12. Jochen Roth voted on patch set 5 V +1 CR +1 09/03/21, 13:02

  13. Benjamin Franzke voted on patch set 5 CR +1 09/03/21, 13:49

  14. Christian Kuhn voted on patch set 5 V +2 CR +2 09/06/21, 11:29

  15. Christian Kuhn merged patch set 6 09/06/21, 11:29