70793[TASK] Add missing direct dependencies
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1825
-
Wouter Wolters uploaded patch set 1 08/26/21, 18:28
-
Wouter Wolters updated the commit message in patch set 2 08/26/21, 18:29
-
core-ci voted on patch set 2 V -1 08/26/21, 18:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15689
-
core-ci voted on patch set 1 V -1 08/26/21, 18:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15688
-
Wouter Wolters uploaded patch set 3 08/26/21, 18:51
-
core-ci voted on patch set 3 V -1 08/26/21, 19:05 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15690
-
Wouter Wolters uploaded patch set 4 08/26/21, 19:15
-
core-ci voted on patch set 4 V +1 08/26/21, 19:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15691
-
Wouter Wolters uploaded patch set 5 09/07/21, 19:34
-
core-ci voted on patch set 5 V -1 09/07/21, 19:42 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16391
-
Wouter Wolters uploaded patch set 6 09/07/21, 19:44
-
Markus Klein commented on patch set 6 09/07/21, 19:56
"from main composer.json"? What do you mean by that? Why do we need them as direct dependencies in the main file? Please add this information briefly to the commit message, that would help a bit. (at least for me). Thanks. -
Wouter Wolters commented on patch set 6 09/07/21, 20:10
Reply
We use these dependencices directly in TYPO3 source. Now these dependencies are downloaded via other dependencies but if these dependencies delete this requirement we have bugs in TYPO3 source because the code does not exist anymore. To prevent that we add them as direct dependencies. This is the same as https://review.typo3.org/c/Packages/TYPO3.CMS/+/70747 -
core-ci voted on patch set 6 V +1 09/07/21, 20:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16395
-
Oliver Klee voted on patch set 6 CR +1 09/07/21, 21:29
-
Rick Septer voted on patch set 6 CR +1 09/08/21, 13:37
-
Markus Klein commented on patch set 6 09/08/21, 14:21
Reply
okay got it. thx -
Christian Kuhn uploaded patch set 7 09/11/21, 10:45
-
Christian Kuhn voted on patch set 7 V +1 CR +1 09/11/21, 10:48
-
Oliver Klee commented on patch set 7 09/11/21, 10:48
composer.json:54If we sort alphabetically, shouldn't this line be above the */psr7 dependency? -
Christian Kuhn commented on patch set 7 09/11/21, 10:59
composer.json:54Replyprobably a rebase thingie ... guess ok to keep, will adapt itself with next composer.json update i assume. -
core-ci voted on patch set 7 V +1 09/11/21, 11:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16534
-
Anja Leichsenring voted on patch set 7 V +2 CR +2 09/11/21, 11:05
-
Anja Leichsenring merged patch set 8 09/11/21, 11:05