Review main Merged

70793[TASK] Add missing direct dependencies

Wouter Wolters CR +2 V +2 Easy +6 −1 updated 09/11/21, 11:05

Commit message

The following dependencies are missing from main composer.json
Add them.

* doctrine/event-manager
* psr/http-server-handler
* guzzlehttp/promises

composer req doctrine/event-manager:^1.0.0 --no-update
composer req psr/http-server-handler:^1.0 --no-update
composer req guzzlehttp/promises:^1.4.0 --no-update

composer req doctrine/event-manager:^1.0.0 -d typo3/sysext/core/ --no-update
composer req psr/http-server-handler:^1.0 -d typo3/sysext/core/ --no-update
composer req guzzlehttp/promises:^1.4.0 -d typo3/sysext/install/ --no-update

composer u --lock

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1825

  1. Wouter Wolters uploaded patch set 1 08/26/21, 18:28

  2. Wouter Wolters updated the commit message in patch set 2 08/26/21, 18:29

  3. core-ci voted on patch set 2 V -1 08/26/21, 18:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15689

  4. core-ci voted on patch set 1 V -1 08/26/21, 18:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15688

  5. Wouter Wolters uploaded patch set 3 08/26/21, 18:51

  6. core-ci voted on patch set 3 V -1 08/26/21, 19:05 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15690

  7. Wouter Wolters uploaded patch set 4 08/26/21, 19:15

  8. core-ci voted on patch set 4 V +1 08/26/21, 19:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15691

  9. Wouter Wolters uploaded patch set 5 09/07/21, 19:34

  10. core-ci voted on patch set 5 V -1 09/07/21, 19:42 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16391

  11. Wouter Wolters uploaded patch set 6 09/07/21, 19:44

  12. Markus Klein commented on patch set 6 09/07/21, 19:56

    "from main composer.json"? What do you mean by that? Why do we need them as direct dependencies in the main file? Please add this information briefly to the commit message, that would help a bit. (at least for me). Thanks.
  13. Wouter Wolters commented on patch set 6 09/07/21, 20:10

    Reply

    We use these dependencices directly in TYPO3 source. Now these dependencies are downloaded via other dependencies but if these dependencies delete this requirement we have bugs in TYPO3 source because the code does not exist anymore. To prevent that we add them as direct dependencies. This is the same as https://review.typo3.org/c/Packages/TYPO3.CMS/+/70747
  14. core-ci voted on patch set 6 V +1 09/07/21, 20:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16395

  15. Oliver Klee voted on patch set 6 CR +1 09/07/21, 21:29

  16. Rick Septer voted on patch set 6 CR +1 09/08/21, 13:37

  17. Markus Klein commented on patch set 6 09/08/21, 14:21

    Reply

    okay got it. thx
  18. Christian Kuhn uploaded patch set 7 09/11/21, 10:45

  19. Christian Kuhn voted on patch set 7 V +1 CR +1 09/11/21, 10:48

  20. Oliver Klee commented on patch set 7 09/11/21, 10:48

    composer.json:54

    If we sort alphabetically, shouldn't this line be above the */psr7 dependency?
  21. Christian Kuhn commented on patch set 7 09/11/21, 10:59

    composer.json:54 Reply

    probably a rebase thingie ... guess ok to keep, will adapt itself with next composer.json update i assume.
  22. Christian Kuhn commented on patch set 7 09/11/21, 10:59

    Reply

    Done

    composer.json:54 Reply

    Done
  23. core-ci voted on patch set 7 V +1 09/11/21, 11:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16534

  24. Anja Leichsenring voted on patch set 7 V +2 CR +2 09/11/21, 11:05

  25. Anja Leichsenring merged patch set 8 09/11/21, 11:05