Review 10.4 Merged

70794[BUGFIX] PSR-7 Uri implementation must return scheme as string

Andreas Kienast CR +2 V +2 Easy +4 −4 updated 08/27/21, 07:42

Commit message

TYPO3's PSR-7 implementation has a small flaw when having URLs
without a scheme, which should always return an empty string.

This change initializes the scheme with an empty string by default.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Andreas Kienast uploaded patch set 1 08/27/21, 07:11

  2. core-ci voted on patch set 1 V +1 08/27/21, 07:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15702

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 08/27/21, 07:42

  4. Andreas Kienast merged patch set 2 08/27/21, 07:42