Review main Merged

70795[BUGFIX] Skip non-existing soft reference parser keys

Nikita Hovratov CR +2 V +2 Easy +43 −5 updated 09/27/21, 10:02

Commit message

Declaring non-existing soft reference parser keys in TCA is ignored
again and won't throw an exception anymore. For informational purposes
this will be logged instead.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1114

  1. Nikita Hovratov uploaded patch set 1 08/27/21, 09:12

  2. core-ci voted on patch set 1 V +1 08/27/21, 09:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15710

  3. Torben Hansen voted on patch set 1 V +1 CR +1 08/27/21, 13:49

  4. Benni Mack commented on patch set 1 08/31/21, 15:09

    SoftReferenceParserFactory.php:110

    I think we should log this information, but not actually do anything. If somebody provides an Extension to scan for "rte_images" but no soft-ref parser is available, it just shouldn't be parsed. This is also good for extensibility and bw-compat.
  5. Nikita Hovratov uploaded patch set 2 09/25/21, 11:50

  6. Nikita Hovratov commented on patch set 2 09/25/21, 11:51

    SoftReferenceParserFactory.php:110 Reply

    Done
  7. core-ci voted on patch set 2 V -1 09/25/21, 12:05 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17182

  8. Nikita Hovratov uploaded patch set 3 09/25/21, 12:26

  9. Nikita Hovratov uploaded patch set 4 09/25/21, 15:12

  10. core-ci voted on patch set 4 V +1 09/25/21, 15:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17188

  11. Benni Mack voted on patch set 4 V +1 CR +1 09/27/21, 08:55

  12. Torben Hansen voted on patch set 4 V +1 CR +1 09/27/21, 09:17

  13. Benni Mack voted on patch set 4 V +2 CR +2 09/27/21, 10:02

  14. Benni Mack merged patch set 5 09/27/21, 10:02