Review main Merged

70797[FEATURE] Add cache:flush console command

Benjamin Franzke CR +2 V +2 Hard +457 −20 updated 08/30/21, 13:35

Commit message

A cache:flush CLI command is added that provides
lowlevel cache flush functionality as in installtool.

It is made extra sure that the command will be executable,
even if all caches are stale or even broken. That means this
command is able to repair broken di, localconf and tca caches.
Technically this became possible due to preparations for
lowlevel cli commands in #86248.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1319

  1. Benjamin Franzke uploaded patch set 1 08/27/21, 11:37

  2. core-ci voted on patch set 1 V -1 08/27/21, 12:09 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15719

  3. Benjamin Franzke uploaded patch set 2 08/27/21, 12:42

  4. Benjamin Franzke wrote 08/27/21, 12:46

    Topic set to cli
  5. core-ci voted on patch set 2 V -1 08/27/21, 13:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15723

  6. Benjamin Franzke rebased onto patch set 3 08/27/21, 15:29

  7. core-ci voted on patch set 3 V +1 08/27/21, 16:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15737

  8. Torben Hansen commented on patch set 3 08/27/21, 17:26

    Feature-90197-IntroduceCacheFlushCommand.rst:12

    Typo "flushp" -> "flush"
  9. Benjamin Franzke uploaded patch set 4 08/27/21, 19:09

  10. Benjamin Franzke commented on patch set 4 08/27/21, 19:09

    Feature-90197-IntroduceCacheFlushCommand.rst:12 Reply

    Done
  11. core-ci voted on patch set 4 V -1 08/27/21, 19:28 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15750

  12. Benjamin Franzke uploaded patch set 5 08/30/21, 06:20

  13. core-ci voted on patch set 5 V +1 08/30/21, 06:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15838

  14. Benjamin Franzke uploaded patch set 6 08/30/21, 10:18

  15. core-ci voted on patch set 6 V +1 08/30/21, 10:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15850

  16. Helmut Hummel voted on patch set 6 V +1 CR +1 08/30/21, 12:39

  17. Oli Bartsch voted on patch set 6 V +1 CR +1 08/30/21, 12:46

  18. Benjamin Franzke voted on patch set 6 V +2 CR +2 08/30/21, 13:34

  19. Benjamin Franzke merged patch set 7 08/30/21, 13:35