Review main Merged

70799[TASK] Enable multi record selection to handle multiple instances

Oli Bartsch CR +2 V +2 Normal +165 −68 updated 08/28/21, 05:00

Commit message

The multi record selection component is now able
to handle multiple instances per page, by using an
unique identifier for each instance.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 57

  1. Oli Bartsch uploaded patch set 1 08/27/21, 15:44

  2. core-ci voted on patch set 1 V -1 08/27/21, 16:05 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15739

  3. core-ci voted on patch set 1 V +1 08/27/21, 16:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15739

  4. Oli Bartsch commented on patch set 1 08/27/21, 17:00

    The new functionality can be tested by adding https://review.typo3.org/c/Packages/TYPO3.CMS/+/70675 on top of this patch. Also multiple task groups should exist.
  5. Benni Mack voted on patch set 1 V +1 CR +1 08/27/21, 20:23

  6. Benjamin Franzke voted on patch set 1 V +2 CR +2 08/28/21, 05:00

  7. Benjamin Franzke merged patch set 2 08/28/21, 05:00