Review main Merged

70803[FEATURE] Implement multi record selection in recodlist

Oli Bartsch CR +2 V +2 Hard +516 −340 updated 09/02/21, 09:12

Commit message

The multi record selection component, introduced
in #94906, is now added to the recordlist as well.

Since the component is not bound to the clipboard
functionality, this will solve a lot of issues,
editors faced when trying to perform actions for
multiple records at once. For example, it was
previously required to activate the clipboard,
change to a numeric "pad" and to copy records
to this pad, before any action could be performed.

This patch also resolves some smaller bugs related
to clipboard actions and does some code cleanup in
the DatabaseRecordList class as well as in the
corresponding JavaScript module.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 9

Review log 2233

Show 48 earlier messages
  1. Oli Bartsch uploaded patch set 1 08/28/21, 00:34

  2. core-ci voted on patch set 1 V -1 08/28/21, 00:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15756

  3. Oli Bartsch uploaded patch set 2 08/30/21, 23:00

  4. core-ci voted on patch set 2 V -1 08/30/21, 23:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15898

  5. Oli Bartsch uploaded patch set 3 08/31/21, 23:37

  6. core-ci voted on patch set 3 V -1 08/31/21, 23:55 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15975

  7. Oli Bartsch uploaded patch set 4 09/01/21, 09:45

  8. core-ci voted on patch set 4 V -1 09/01/21, 10:13 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15999

  1. Benni Mack commented on patch set 4 09/01/21, 11:37

    DatabaseRecordList.php:440

    this will be an issue for the "Download/Export" feature, needs to be inside $includeMetaColumns
  2. Oli Bartsch uploaded patch set 5 09/01/21, 13:05

  3. Oli Bartsch commented on patch set 5 09/01/21, 13:07

    DatabaseRecordList.php:440 Reply

    Done
  4. core-ci voted on patch set 5 V -1 09/01/21, 13:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16010

  5. Oli Bartsch uploaded patch set 6 09/01/21, 13:26

  6. core-ci voted on patch set 6 V -1 09/01/21, 13:45 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16012

  7. Oli Bartsch uploaded patch set 7 09/01/21, 13:56

  8. core-ci voted on patch set 7 V -1 09/01/21, 14:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16014

  9. Oli Bartsch uploaded patch set 8 09/01/21, 16:27

  10. core-ci voted on patch set 8 V -1 09/01/21, 16:41 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16017

  11. Oli Bartsch uploaded patch set 9 09/01/21, 18:04

  12. core-ci voted on patch set 9 V +1 09/01/21, 18:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16022

  13. Nikita Hovratov uploaded patch set 10 09/02/21, 07:47

  14. Nikita Hovratov uploaded patch set 11 09/02/21, 07:54

  15. core-ci voted on patch set 10 V +1 09/02/21, 08:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16051

  16. core-ci voted on patch set 11 V +1 09/02/21, 08:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16053

  17. Jochen Roth commented on patch set 11 09/02/21, 08:22

    Nice feature! The "Add to clipboard" Button does not have a label. Wouldn't it make sense to add a label here?
  18. Jochen Roth commented on patch set 11 09/02/21, 08:38

    Reply

    Bloody cache... Looks good! Sorry for the noise.
  19. Benni Mack voted on patch set 11 V +1 09/02/21, 08:52

  20. Nikita Hovratov commented on patch set 11 09/02/21, 08:55

    Reply

    Maybe cache? For me it has "Transfer to clipboard".
  21. Nikita Hovratov voted on patch set 11 V +1 CR +1 09/02/21, 08:56

  22. Benni Mack voted on patch set 11 CR +1 09/02/21, 09:02

  23. Jochen Roth voted on patch set 11 V +1 CR +1 09/02/21, 09:04

  24. Oli Bartsch voted on patch set 11 V +2 CR +2 09/02/21, 09:12

  25. Oli Bartsch merged patch set 12 09/02/21, 09:12