Review main Merged

70805[TASK] Use extension source paths in icon API

Helmut Hummel CR +2 V +2 Normal +101 −53 updated 09/03/21, 11:54

Commit message

Also introduce internal PathUtility API to resolve
the web path of extension resources and a helper
public API method to check whether a path is an
extension resource path.

Start using the new API throughout the core.
All checks of EXT prefix are replaced,
further usages of getAbsoluteWebPath will
be replaced in subsequent patches.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 23

Show 3 more files

Review log 1014

  1. Helmut Hummel uploaded patch set 1 08/28/21, 13:04

  2. Helmut Hummel uploaded patch set 2 08/28/21, 13:26

  3. core-ci voted on patch set 1 V +1 08/28/21, 13:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15770

  4. core-ci voted on patch set 2 V -1 08/28/21, 13:48 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15771

  5. Helmut Hummel uploaded patch set 3 08/30/21, 00:14

  6. core-ci voted on patch set 3 V -1 08/30/21, 00:30 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15833

  7. Benni Mack commented on patch set 3 08/30/21, 07:26

    Great and important change. Wanted to do this for a long time!
  8. Helmut Hummel rebased onto patch set 4 08/30/21, 15:12

  9. core-ci voted on patch set 4 V +1 08/30/21, 15:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15876

  10. Benni Mack voted on patch set 4 V +1 CR +1 08/31/21, 14:55

  11. Nikita Hovratov voted on patch set 4 CR +1 08/31/21, 17:17

  12. Oli Bartsch voted on patch set 4 V +1 CR +1 09/03/21, 11:54

  13. Benni Mack voted on patch set 4 V +2 CR +2 09/03/21, 11:54

  14. Benni Mack merged patch set 5 09/03/21, 11:54