Review main Merged

70806[TASK] Raise typo3/testing-framework:^6.10.0

Christian Kuhn CR +2 V +2 Easy +16 −12 updated 08/29/21, 16:10

Commit message

This minor version raise brings significant
performance improvements for functional tests,
especially with mysql/mariadb & sqlite.

composer req --dev typo3/testing-framework:^6.10.0

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 2037

Show 612 earlier messages
  1. Christian Kuhn uploaded patch set 1 08/28/21, 14:08

  2. core-ci voted on patch set 1 V +1 08/28/21, 14:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15772

  3. core-ci voted on patch set 1 V -1 08/28/21, 14:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15774

  4. Christian Kuhn voted on patch set 1 CR -2 08/28/21, 14:43

  5. Christian Kuhn uploaded patch set 2 08/28/21, 15:09

  6. Christian Kuhn uploaded patch set 3 08/28/21, 15:13

  7. core-ci voted on patch set 2 V -1 08/28/21, 15:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15776

  8. core-ci voted on patch set 3 V -1 08/28/21, 15:33 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15778

  9. Christian Kuhn uploaded patch set 4 08/28/21, 20:33

  10. core-ci voted on patch set 4 V +1 08/28/21, 20:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15791

  11. core-ci voted on patch set 4 V -1 08/28/21, 21:18 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15793

  12. Christian Kuhn uploaded patch set 5 08/28/21, 21:40

  1. core-ci voted on patch set 5 V +1 08/28/21, 21:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15796

  2. core-ci commented on patch set 5 08/28/21, 22:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15797

  3. Christian Kuhn uploaded patch set 6 08/29/21, 00:03

  4. core-ci voted on patch set 6 V +1 08/29/21, 00:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15798

  5. core-ci commented on patch set 6 08/29/21, 00:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15800

  6. Christian Kuhn uploaded patch set 7 08/29/21, 01:53

  7. core-ci voted on patch set 7 V +1 08/29/21, 02:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15803

  8. Christian Kuhn uploaded patch set 8 08/29/21, 08:09

  9. core-ci voted on patch set 8 V +1 08/29/21, 08:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15806

  10. core-ci commented on patch set 8 08/29/21, 08:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15809

  11. Christian Kuhn uploaded patch set 9 08/29/21, 12:11

  12. core-ci voted on patch set 9 V -1 08/29/21, 12:25 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15811

  13. Christian Kuhn voted on patch set 9 CR 0 08/29/21, 13:40

  14. Christian Kuhn uploaded patch set 10 08/29/21, 14:01

  15. core-ci voted on patch set 10 V +1 08/29/21, 14:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15815

  16. Christian Kuhn uploaded patch set 11 08/29/21, 14:29

  17. core-ci voted on patch set 11 V +1 08/29/21, 14:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15822

  18. core-ci commented on patch set 10 08/29/21, 15:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15817

  19. Stefan Bürk voted on patch set 11 V +1 CR +1 08/29/21, 15:13

  20. Wouter Wolters voted on patch set 11 V +1 CR +1 08/29/21, 15:25

  21. Anja Leichsenring voted on patch set 11 V +2 CR +2 08/29/21, 15:30

  22. Anja Leichsenring merged patch set 12 08/29/21, 15:31

  23. Alexander Nitsche commented on patch set 11 08/29/21, 15:32

    (1) Should the other sqlite docker setup in Build/testing-docker/local/docker-compose.yml also use tmpfs? - acceptance_install_sqlite (2) Should the acceptance test gitlab setup change be mentioned in the commit message?
  24. Christian Kuhn commented on patch set 12 08/29/21, 15:37

    Reply Unresolved

    the ac test does not work with that tmpfs change (yet?). the gitlab job shifting is imho a bit internal, the performance change much more important, i thus decided to not mention that.
  25. Oliver Klee voted on patch set 12 V +1 CR +1 08/29/21, 16:10