70810[TASK] Unify core cache identifiers
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 37
- typo3/sysext/backend/Classes/ServiceProvider.php+3 −4
- typo3/sysext/core/Classes/DependencyInjection/ContainerBuilder.php+5 −5
- typo3/sysext/core/Classes/ExpressionLanguage/ProviderConfigurationLoader.php+3 −2
- typo3/sysext/core/Classes/Http/MiddlewareStackResolver.php+6 −4
- typo3/sysext/core/Classes/Imaging/IconProvider/FontawesomeIconProvider.php+6 −10
- typo3/sysext/core/Classes/Imaging/IconRegistry.php+5 −4
- typo3/sysext/core/Classes/Package/Cache/PackageDependentCacheIdentifier.php10new+60 −0
- typo3/sysext/core/Classes/Page/PageRenderer.php+7 −3
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php5+4 −4
- typo3/sysext/core/Classes/ServiceProvider.php+11 −4
- typo3/sysext/core/Configuration/Services.yaml+1 −0
- typo3/sysext/core/Tests/Unit/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcherTest.php+2 −1
- typo3/sysext/core/Tests/Unit/ExpressionLanguage/ResolverTest.php+2 −1
- typo3/sysext/core/Tests/Unit/Http/MiddlewareStackResolverTest.php+8 −4
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/FontawesomeIconProviderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Imaging/IconFactoryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Imaging/IconRegistryTest.php+17 −17
- typo3/sysext/core/Tests/Unit/Imaging/IconTest.php+1 −1
- typo3/sysext/dashboard/Classes/ServiceProvider.php+9 −17
- typo3/sysext/extbase/Classes/Configuration/RequestHandlersConfigurationFactory.php+6 −7
Show 17 more files
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapFactory.php+7 −5
- typo3/sysext/extbase/Classes/Persistence/ClassesConfigurationFactory.php+6 −7
- typo3/sysext/extbase/Classes/Reflection/ReflectionService.php3+6 −7
- typo3/sysext/extbase/Classes/ServiceProvider.php+2 −1
- typo3/sysext/extbase/Configuration/Services.yaml+6 −0
- typo3/sysext/extbase/Tests/Functional/Configuration/RequestHandlerConfigurationFactoryTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/View/JsonViewTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Object/Container/ContainerTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+2 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Persistence/ClassesConfigurationFactoryTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchemaTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Reflection/ObjectAccessTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Reflection/ReflectionServiceTest.php+4 −4
- typo3/sysext/extbase/Tests/UnitDeprecated/Object/Container/ContainerTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+2 −1
- typo3/sysext/t3editor/Classes/T3editor.php+7 −7
Review log 3749
Show 1624 earlier messages
-
Helmut Hummel uploaded patch set 1 08/28/21, 20:24
-
Helmut Hummel uploaded patch set 2 08/28/21, 20:25
-
core-ci voted on patch set 1 V -1 08/28/21, 20:29 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15788
-
core-ci voted on patch set 2 V -1 08/28/21, 20:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15789
-
Benni Mack rebased onto patch set 3 08/30/21, 06:15
-
core-ci voted on patch set 3 V -1 08/30/21, 06:19 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15837
-
Benjamin Franzke commented on patch set 3 08/30/21, 06:23
-
Benni Mack commented on patch set 3 09/02/21, 09:47
ExtensionManagementUtility.php:1487ReplyHow about putting this into PackageManager? -
Benjamin Franzke commented on patch set 3 09/02/21, 11:35
ExtensionManagementUtility.php:1487ReplyWell, we rather not want to inject PackageManager everywhere, just for the cache identifier usage, therefore we thought it would be better to use a specific service instead of a "god" service. We ended up with naming it "PackageDependentCacheIdentifier->create()". Helmut wanted to continue with that, maybe he got sidetracked. -
Helmut Hummel commented on patch set 3 09/29/21, 14:32
ExtensionManagementUtility.php:1487Replyyeah. will pick it up now -
Helmut Hummel uploaded patch set 4 09/29/21, 15:52
-
core-ci voted on patch set 4 V -1 09/29/21, 16:08 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17317
-
Helmut Hummel uploaded patch set 5 09/29/21, 19:20
-
Helmut Hummel commented on patch set 5 09/29/21, 19:21
ExtensionManagementUtility.php:1487ReplyDone -
core-ci voted on patch set 5 V -1 09/29/21, 19:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17320
-
Helmut Hummel uploaded patch set 6 09/29/21, 19:52
-
core-ci voted on patch set 6 V -1 09/29/21, 20:12 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17321
-
Benni Mack commented on patch set 6 09/30/21, 09:47
ReflectionService.php:81should we use GeneralUtility::getContainer()->get() here? -
Benjamin Franzke commented on patch set 6 09/30/21, 12:41
ReflectionService.php:81ReplyWe should inject PackageDependentCacheIdentifier. Talked with helmut via slack yesterday and we agreed to fix some extbase DI things first in the following preparatoy patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71376 -
Helmut Hummel uploaded patch set 7 10/01/21, 10:26
-
Helmut Hummel commented on patch set 7 10/01/21, 10:28
ReflectionService.php:81ReplyAck -
core-ci voted on patch set 7 V -1 10/01/21, 10:47 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17401
-
Benjamin Franzke uploaded patch set 8 10/01/21, 14:03
-
core-ci voted on patch set 8 V -1 10/01/21, 14:08 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17439
-
Benjamin Franzke uploaded patch set 9 10/01/21, 15:20
-
Xavier Perseguers commented on patch set 9 10/01/21, 15:33
PackageDependentCacheIdentifier.php:38Nitpicking but would have preferred reading __toString() -
core-ci voted on patch set 9 V +1 10/01/21, 15:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17449
-
Benjamin Franzke commented on patch set 9 10/01/21, 17:19
PackageDependentCacheIdentifier.php:38ReplyWouldn't look very nice if we then (still) need to call it explicitly in symfony expressions with `__toString()`. Therefore I personally think toString() is fine for this case. Do you agree? -
Helmut Hummel commented on patch set 9 10/01/21, 21:52
PackageDependentCacheIdentifier.php:38ReplyI also always learned to appreciate explicit code over implicit code. -
Xavier Perseguers commented on patch set 9 10/02/21, 06:31
PackageDependentCacheIdentifier.php:38ReplyFine with me, I just prefer sticking to the programming language paradigms while still being explicit. There's an official way of converting an object to a string which is casting thus using `(string)` as prefix and you can tell PHP how to do the casting by overriding the method `__toString()`. I find it much better than inventing a `toString()` method which basically does the same but doesn't allow either casting or implicit casting. Again, it's possibly just a matter of taste, this is why I wrote that's a bit nitpicking but I still consider that I prefer sticking to the language whenever I can instead of inventing something looking similar. -
Xavier Perseguers commented on patch set 9 10/02/21, 06:33
PackageDependentCacheIdentifier.php:38Replyand btw, we use an explicit casting of some object to (string) a lot already in Core, so it's not like it would be coming from nowhere :) -
Benjamin Franzke commented on patch set 9 10/02/21, 06:37
PackageDependentCacheIdentifier.php:38ReplyStill, please consider the usage in symfony expressions, __toString() would be ugly there. I think it's good in this case. Would agree otherwise (for consistency). -
Xavier Perseguers commented on patch set 9 10/02/21, 06:39
PackageDependentCacheIdentifier.php:38ReplyOK, fine then, it's then a severe limitation of Symphony not smart enough to take advantage of casting and this "feature" in most programming languages. -
Benjamin Franzke commented on patch set 9 10/02/21, 07:40
PackageDependentCacheIdentifier.php:38ReplySorry, i was wrong. we could use __toString() as php will auto cast due to the `string` type declaration. @Helmut: I'd be fine either way.. Remove `.toString()` would actually look better in the expressions. -
Nikita Hovratov uploaded patch set 10 10/02/21, 08:03
-
Helmut Hummel commented on patch set 10 10/02/21, 08:10
PackageDependentCacheIdentifier.php:38ReplyAs I said, I think code benefits from being explicit. If I sxplicity call toString, I immediately know and understand than this is an object that can be converted to a string, while when I just string concatenate two variables, I must know that they are indeed castable or strings. However if this REALLY is the only thing to complain and a blocker for this change to be merged, then I'll accept implicitly here. -
Nikita Hovratov uploaded patch set 11 10/02/21, 08:16
-
core-ci voted on patch set 10 V +1 10/02/21, 08:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17474
-
Benjamin Franzke commented on patch set 11 V +1 CR +1 10/02/21, 08:19
PackageDependentCacheIdentifier.php:38ReplyOk, have to correct myself: a) auto casting wont work with declare(strict_types=1; b) symfony DI/expressions not warn about that in expressions This patch is good as is. Thanks for discussion anyway. -
Nikita Hovratov voted on patch set 11 V +1 CR +1 10/02/21, 08:28
-
core-ci voted on patch set 11 V +1 10/02/21, 08:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17475
-
Nikita Hovratov commented on patch set 11 CR -1 10/02/21, 08:33
One missed place found in: typo3/sysext/core/Classes/Imaging/IconProvider/FontawesomeIconProvider->getCacheIdentifier -
Nikita Hovratov uploaded patch set 12 10/02/21, 08:59
-
Benjamin Franzke voted on patch set 12 V +1 CR +1 10/02/21, 09:10
-
Nikita Hovratov voted on patch set 12 V +1 CR +1 10/02/21, 09:18
-
core-ci voted on patch set 12 V +1 10/02/21, 09:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17479
-
Benjamin Franzke voted on patch set 12 V +2 CR +2 10/02/21, 09:28
-
Benjamin Franzke merged patch set 13 10/02/21, 09:28
-
Helmut Hummel commented on patch set 13 10/02/21, 14:40
Reply
Actually, I left this out intentionally, because this cache does NOT depend on loaded packages
ExtensionManagementUtility.php:1487